Use mul nuw nsw in intrinsics::copy#157588
Merged
Merged
Conversation
Essentially the same as 157560, just for `copy` instead of `copy_nonoverlapping`.
rustbot
added
S-waiting-on-review
Member
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 8, 2026
Use `mul nuw nsw` in `intrinsics::copy`
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (7895196): comparison URL. Overall result: no relevant changes - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 5.6%, secondary -0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 516.04s -> 515.731s (-0.06%) |
rustbot
removed
the
S-waiting-on-perf
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 8, 2026
…uwer Rollup of 9 pull requests Successful merges: - #157599 (`rust-analyzer` subtree update) - #157298 (Use alternate means of detecting enums in `is_udt`) - #155338 (Staticlib hide internal symbols) - #157402 (Implement feature `integer_casts`) - #157452 (Fix WASI links) - #157535 (Rename `errors.rs` file to `diagnostics.rs` (2/N)) - #157585 (Rename `errors.rs` file to `diagnostics.rs` (3/N)) - #157588 (Use `mul nuw nsw` in `intrinsics::copy`) - #157592 (Suggest comma multiple)
rust-timer
added a commit
that referenced
this pull request
Jun 8, 2026
Rollup merge of #157588 - scottmcm:copy-nsuw, r=saethlin Use `mul nuw nsw` in `intrinsics::copy` Essentially the same as #157560, just for `copy` instead of `copy_nonoverlapping`. > Yeah, in fact both copy and copy_nonoverlapping could use this since we know the result must be at most isize::MAX else it cannot be inbounds. > ~ #157560 (comment) r? saethlin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentially the same as #157560, just for
copyinstead ofcopy_nonoverlapping.r? saethlin