Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow trailing commas in bitflags! macro #16986
Conversation
This comment has been minimized.
This comment has been minimized.
|
Looks good to me! r=me with a rebase |
brendanzab
added some commits
Sep 4, 2014
brendanzab
force-pushed the
brendanzab:bitflags
branch
from
32bf88f
to
ef354d8
Sep 4, 2014
This comment has been minimized.
This comment has been minimized.
|
r=alexcrichton |
This comment has been minimized.
This comment has been minimized.
|
saw approval from alexcrichton |
This comment has been minimized.
This comment has been minimized.
|
merging bjz/rust/bitflags = ef354d8 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = e024017 |
bors
added a commit
that referenced
this pull request
Sep 4, 2014
bors
closed this
Sep 4, 2014
bors
merged commit ef354d8
into
rust-lang:master
Sep 4, 2014
1 of 2 checks passed
continuous-integration/travis-ci
The Travis CI build failed
Details
default
all tests passed
brendanzab
deleted the
brendanzab:bitflags
branch
Sep 4, 2014
This comment has been minimized.
This comment has been minimized.
theemathas
commented on ca60b74
Jan 16, 2015
|
Seriously, what exactly is this commit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
brendanzab commentedSep 4, 2014
Closes #16469