New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICE regression test with unboxed closures #17093

Merged
merged 1 commit into from Sep 9, 2014

Conversation

Projects
None yet
4 participants
@nathantypanski
Contributor

nathantypanski commented Sep 8, 2014

This code used to produce the following ICE:

error: internal compiler error: get_unique_type_id_of_type() -
unexpected type: closure,
ty_unboxed_closure(syntax::ast::DefId{krate: 0u32, node: 66u32},
ReScope(63u32))

This is a regression test for issue #17021.

Add ICE regression test with unboxed closures
This code used to produce the following ICE:

   error: internal compiler error: get_unique_type_id_of_type() -
   unexpected type: closure,
   ty_unboxed_closure(syntax::ast::DefId{krate: 0u32, node: 66u32},
   ReScope(63u32))

This is a regression test for issue #17021.
@nrc

This comment has been minimized.

nrc commented on a1d9010 Sep 8, 2014

r+

@brson

This comment has been minimized.

Contributor

brson commented Sep 8, 2014

<3 tests

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 9, 2014

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 9, 2014

@bors bors merged commit a1d9010 into rust-lang:master Sep 9, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

nathantypanski added a commit to nathantypanski/rust that referenced this pull request Sep 12, 2014

add debuginfo for unboxed closures
This catches two unhandled patterns in middle/trans/debuginfo.rs where a
ty::ty_unboxed_closure could show up, preventing various potential ICEs
when #[feature(unboxed_closures)] is used with `-g`.

It also updates the test case from rust-lang#17093 in response to new information
from rust-lang#17021 showing that the test still caused an ICE when compiling
with debuginfo.

Closes rust-lang#17021.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment