Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICE regression test with unboxed closures #17093

Merged
merged 1 commit into from
Sep 9, 2014

Conversation

nathantypanski
Copy link
Contributor

This code used to produce the following ICE:

error: internal compiler error: get_unique_type_id_of_type() -
unexpected type: closure,
ty_unboxed_closure(syntax::ast::DefId{krate: 0u32, node: 66u32},
ReScope(63u32))

This is a regression test for issue #17021.

This code used to produce the following ICE:

   error: internal compiler error: get_unique_type_id_of_type() -
   unexpected type: closure,
   ty_unboxed_closure(syntax::ast::DefId{krate: 0u32, node: 66u32},
   ReScope(63u32))

This is a regression test for issue rust-lang#17021.
@brson
Copy link
Contributor

brson commented Sep 8, 2014

<3 tests

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 9, 2014
@bors bors merged commit a1d9010 into rust-lang:master Sep 9, 2014
nathantypanski added a commit to nathantypanski/rust that referenced this pull request Sep 12, 2014
This catches two unhandled patterns in middle/trans/debuginfo.rs where a
ty::ty_unboxed_closure could show up, preventing various potential ICEs
when #[feature(unboxed_closures)] is used with `-g`.

It also updates the test case from rust-lang#17093 in response to new information
from rust-lang#17021 showing that the test still caused an ICE when compiling
with debuginfo.

Closes rust-lang#17021.
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
…Veykril

fix: VFS should not walk circular symlinks

As of rust-lang#6246, rust-analyzer follows symlinks. This can introduce an infinite loop if symlinks point to parent directories.

Considering that rust-lang#6246 was added in 2020 without many bug reports, this is clearly a rare occurrence. However, I am observing rust-analyzer hang on projects that have symlinks of the form:

```
test/a_symlink -> ../../
```

Ignore symlinks that only point to the parent directories, as this is more robust but still allows typical symlink usage patterns.
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
…Veykril

fix: VFS should not walk circular symlinks

As of rust-lang#6246, rust-analyzer follows symlinks. This can introduce an infinite loop if symlinks point to parent directories.

Considering that rust-lang#6246 was added in 2020 without many bug reports, this is clearly a rare occurrence. However, I am observing rust-analyzer hang on projects that have symlinks of the form:

```
test/a_symlink -> ../../
```

Ignore symlinks that only point to the parent directories, as this is more robust but still allows typical symlink usage patterns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants