New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Z no-opt flag. #17419

Merged
merged 1 commit into from Sep 22, 2014

Conversation

Projects
None yet
4 participants
@AnchoviesHat
Contributor

AnchoviesHat commented Sep 21, 2014

Closes #13649

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Sep 21, 2014

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

Collaborator

rust-highfive commented Sep 21, 2014

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

@huonw

This comment has been minimized.

Show comment
Hide comment
@huonw

huonw Sep 21, 2014

Member

I'm not in favour of this just yet, at least until we have (a plan for) an equivalent way to disable optimisations with the Rust makeflies. If you want to build something unoptimised the choices are make <target> RUSTFLAGS='-Z no-opt', or extracting the correct compiler invocations and removing the -O flags, the former is definitely easier. (Reconfiguring with --disable-optimize doesn't quite do the same thing, since that would require redoing the whole bootstrap without optimisation, while RUSTFLAGS allows for a quicker edit-compile cycle.)

If, e.g., the Rust makefiles removed the -O flag when passed NO_OPT, or set --opt-level to n when given OPT_LEVEL=n then this is good. (This handling all seems to be around line 111 of mk/main.mk, if you feel like tackling it.)

Member

huonw commented Sep 21, 2014

I'm not in favour of this just yet, at least until we have (a plan for) an equivalent way to disable optimisations with the Rust makeflies. If you want to build something unoptimised the choices are make <target> RUSTFLAGS='-Z no-opt', or extracting the correct compiler invocations and removing the -O flags, the former is definitely easier. (Reconfiguring with --disable-optimize doesn't quite do the same thing, since that would require redoing the whole bootstrap without optimisation, while RUSTFLAGS allows for a quicker edit-compile cycle.)

If, e.g., the Rust makefiles removed the -O flag when passed NO_OPT, or set --opt-level to n when given OPT_LEVEL=n then this is good. (This handling all seems to be around line 111 of mk/main.mk, if you feel like tackling it.)

@AnchoviesHat

This comment has been minimized.

Show comment
Hide comment
@AnchoviesHat

AnchoviesHat Sep 21, 2014

Contributor

It looks like this can already be achieved with CFG_DISABLE_OPTIMIZE=1 make.

Contributor

AnchoviesHat commented Sep 21, 2014

It looks like this can already be achieved with CFG_DISABLE_OPTIMIZE=1 make.

@bors

This comment has been minimized.

Show comment
Hide comment
Contributor

bors commented on b2b0737 Sep 21, 2014

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 21, 2014

Contributor

merging anchovieshat/rust/remove_no_opt = b2b0737 into auto

Contributor

bors replied Sep 21, 2014

merging anchovieshat/rust/remove_no_opt = b2b0737 into auto

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 21, 2014

Contributor

anchovieshat/rust/remove_no_opt = b2b0737 merged ok, testing candidate = 4e5b626

Contributor

bors replied Sep 21, 2014

anchovieshat/rust/remove_no_opt = b2b0737 merged ok, testing candidate = 4e5b626

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 22, 2014

Contributor

fast-forwarding master to auto = 4e5b626

Contributor

bors replied Sep 22, 2014

fast-forwarding master to auto = 4e5b626

bors added a commit that referenced this pull request Sep 21, 2014

@bors bors closed this Sep 22, 2014

@bors bors merged commit b2b0737 into rust-lang:master Sep 22, 2014

1 of 2 checks passed

continuous-integration/travis-ci The Travis CI build failed
Details
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment