Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ty_bot from the type system #17603

Closed
wants to merge 3 commits into from

Conversation

Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rust-highfive @nikomatsakis @alexcrichton @bors
@ghost
Copy link

ghost commented Sep 28, 2014

We now instead use a fresh variable for expressions that diverge.

Closes #14973.
Closes #13847.

[Work in progress]

cc @nikomatsakis
@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Sep 28, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Oct 8, 2014

@jakub- assigning myself, sorry for delay, it's been a busy week or so.

@nikomatsakis nikomatsakis self-assigned this Oct 8, 2014

@ghost

This comment has been minimized.

Sign in to view
Copy link
Author

ghost commented Oct 11, 2014

@nikomatsakis Thanks. This PR isn't compiling yet, AFAIR, due to some unconstrained variables in rustc but the general direction is mostly set. I will rebase soon.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Oct 24, 2014

ping @jakub-, any updates here?
@ghost

This comment has been minimized.

Sign in to view
Copy link
Author

ghost commented Oct 24, 2014

@alexcrichton @nikomatsakis This now bootstraps so I'd appreciate your review.
@ghost

This comment has been minimized.

Sign in to view
Copy link
Author

ghost commented Oct 25, 2014

This is green now.

Jakub Bukaj added some commits Oct 24, 2014

Jakub Bukaj
Remove ty_bot from the type system 
We now instead use a fresh variable for expressions that diverge.
cca84e9
Jakub Bukaj
Update tests with the new error messages
Loading status checks…
7f523e7
Jakub Bukaj
Address review comments
Loading status checks…
6d2080c
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented on 6d2080c Oct 28, 2014

saw approval from nikomatsakis
at https://github.com/jakub-/rust/commit/6d2080c44878924bdcde57ec7735327af0ee267d

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors replied Oct 28, 2014

merging jakub-/rust/ty_bot = 6d2080c into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors replied Oct 28, 2014

jakub-/rust/ty_bot = 6d2080c merged ok, testing candidate = 1652a1f

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors replied Oct 29, 2014

fast-forwarding master to auto = 1652a1f

bors added a commit that referenced this pull request Oct 28, 2014

@bors
auto merge of #17603 : jakub-/rust/ty_bot, r=nikomatsakis 
We now instead use a fresh variable for expressions that diverge.

Closes #14973.
Closes #13847.

[Work in progress]

cc @nikomatsakis
Loading status checks…
1652a1f

@bors bors closed this Oct 29, 2014

@ghost ghost deleted the ty_bot branch Oct 29, 2014

@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented Oct 30, 2014

Nice work.
@ghost

This comment has been minimized.

Sign in to view
Copy link
Author

ghost commented Oct 30, 2014

@nikomatsakis Cheers!

@pnkfelix pnkfelix referenced this pull request Feb 3, 2015

Closed

Type ambiguity not reported when it may exist? #21878

edwardw added a commit to edwardw/rust that referenced this pull request Feb 6, 2015

@edwardw
Make bottom type fallback lazy 
PR rust-lang#17603 introduced bottom type fallback but did it a bit too
eagerly. This patch makes the fallback lazy so that `typeck` can run
its cause and detect as many type errors as possible with regard to
diverging types.

Closes rust-lang#21878
943f62c

@edwardw edwardw referenced this pull request Feb 6, 2015

Closed

Make bottom type fallback lazy #22010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.