Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gc (garbage "collected") boxes. #17666

Merged
merged 13 commits into from Oct 3, 2014

Conversation

@eddyb
Copy link
Member

commented Sep 30, 2014

All good things must come to an end. Even the really bad ones.

[breaking-change] (hopefully nobody was using it)

Closes #17668.

@eddyb

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2014

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Sep 30, 2014

An absolutely heroic effort made by @eddyb leading up to this, amazing work!

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

Very impressive.

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2014

Read everything up until the WIP commit. R+ to all those modulo nits.

@eddyb eddyb force-pushed the eddyb:take-garbage-out branch from 3277075 to 78f9512 Oct 1, 2014
@eddyb eddyb changed the title [WIP] Remove Gc (garbage "collected") boxes. Remove Gc (garbage "collected") boxes. Oct 1, 2014
@eddyb eddyb force-pushed the eddyb:take-garbage-out branch 2 times, most recently from ab07550 to ca87704 Oct 1, 2014
@eddyb eddyb force-pushed the eddyb:take-garbage-out branch from ca87704 to 58bea31 Oct 2, 2014
@pcwalton

This comment has been minimized.

Copy link

commented on 58bea31 Oct 2, 2014

r+

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 2, 2014
Conflicts:
	src/libcollections/lib.rs
	src/libcore/lib.rs
	src/librustdoc/lib.rs
	src/librustrt/lib.rs
	src/libserialize/lib.rs
	src/libstd/lib.rs
	src/test/run-pass/issue-8898.rs
@bors bors merged commit 58bea31 into rust-lang:master Oct 3, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
@eddyb eddyb deleted the eddyb:take-garbage-out branch Oct 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.