Add comments with type annotations. #19743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/doc/guide.md
Outdated
Contributor
Author
There was a problem hiding this comment.
thanks, fixing
steveklabnik
force-pushed
the
gh16143
branch
from
6c3da27 to
ba5dfd9
Compare
This will hopefully help people with their first steps in Rust. Fixes rust-lang#16143.
steveklabnik
force-pushed
the
gh16143
branch
from
ba5dfd9 to
31b240d
Compare
bors
added a commit
that referenced
this pull request
Dec 16, 2014
Add comments with type annotations. Reviewed-by: alexcrichton
bors
referenced
this pull request
Dec 16, 2014
Using a type alias for iterator implementations is fragile since this exposes the implementation to users of the iterator, and any changes could break existing code. This commit changes the iterators of `VecMap` to use proper new types, rather than type aliases. However, since it is fair-game to treat a type-alias as the aliased type, this is a: [breaking-change].
bors
added a commit
that referenced
this pull request
Dec 16, 2014
Add comments with type annotations. Reviewed-by: alexcrichton
brson
added a commit
to brson/rust
that referenced
this pull request
Dec 16, 2014
This will hopefully help people with their first steps in Rust. Fixes rust-lang#16143. /cc @jvns
bors
added a commit
that referenced
this pull request
Dec 17, 2014
Add comments with type annotations. Reviewed-by: alexcrichton
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 17, 2014
This will hopefully help people with their first steps in Rust. Fixes rust-lang#16143. /cc @jvns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will hopefully help people with their first steps in Rust.
Fixes #16143.
/cc @jvns