Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LLVM ExecutionEngine API #19750

Merged
merged 2 commits into from Dec 15, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@murarth @Gankro @brson @bors
@murarth
Copy link
Contributor

murarth commented Dec 11, 2014

Makes a couple changes that support the implementation of a REPL:

  • Implementation of wrapper code for LLVM ExecutionEngine API
  • Fixing a change I made earlier to reset compiler state in phase_1_[...]
    instead of compile_input as the latter is not used in a REPL
@Gankro

This comment has been minimized.

Sign in to view
Copy link
Contributor

Gankro commented Dec 12, 2014

r? @thestinger

@murarth murarth changed the title Support for implementation of a Rust REPL Implement LLVM ExecutionEngine API Dec 12, 2014

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Dec 12, 2014

Although adding a JIT and REPL is a big decision that we shouldn't make lightly, this groundwork looks pretty unobjectionable to me. Thanks.

brson added a commit to brson/rust that referenced this pull request Dec 12, 2014

@brson
rollup merge of rust-lang#19750: murarth/rusti-support 
Makes a couple changes that support the implementation of a REPL:

* Implementation of wrapper code for LLVM ExecutionEngine API
* Fixing a change I made earlier to reset compiler state in `phase_1_[...]`
  instead of `compile_input` as the latter is not used in a REPL
b10907c

brson added a commit to brson/rust that referenced this pull request Dec 13, 2014

@brson
rollup merge of rust-lang#19750: murarth/rusti-support 
Makes a couple changes that support the implementation of a REPL:

* Implementation of wrapper code for LLVM ExecutionEngine API
* Fixing a change I made earlier to reset compiler state in `phase_1_[...]`
  instead of `compile_input` as the latter is not used in a REPL
b8ccc50

brson added a commit to brson/rust that referenced this pull request Dec 14, 2014

@brson
rollup merge of rust-lang#19750: murarth/rusti-support 
Makes a couple changes that support the implementation of a REPL:

* Implementation of wrapper code for LLVM ExecutionEngine API
* Fixing a change I made earlier to reset compiler state in `phase_1_[...]`
  instead of `compile_input` as the latter is not used in a REPL
a1ad9eb

brson added a commit to brson/rust that referenced this pull request Dec 14, 2014

@brson
rollup merge of rust-lang#19750: murarth/rusti-support 
Makes a couple changes that support the implementation of a REPL:

* Implementation of wrapper code for LLVM ExecutionEngine API
* Fixing a change I made earlier to reset compiler state in `phase_1_[...]`
  instead of `compile_input` as the latter is not used in a REPL
6b4f1e2

bors added a commit that referenced this pull request Dec 14, 2014

@bors
Merge pull request #19750 from murarth/rusti-support 
Implement LLVM ExecutionEngine API

Reviewed-by: brson
98fa413
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented on 04b4b50 Dec 15, 2014

saw approval from brson
at murarth@04b4b50

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors replied Dec 15, 2014

merging murarth/rust/rusti-support = 04b4b50 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors replied Dec 15, 2014

murarth/rust/rusti-support = 04b4b50 merged ok, testing candidate = b677746

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors replied Dec 15, 2014

fast-forwarding master to auto = b677746

bors added a commit that referenced this pull request Dec 15, 2014

@bors
auto merge of #19750 : murarth/rust/rusti-support, r=brson 
Makes a couple changes that support the implementation of a REPL:

* Implementation of wrapper code for LLVM ExecutionEngine API
* Fixing a change I made earlier to reset compiler state in `phase_1_[...]`
  instead of `compile_input` as the latter is not used in a REPL
Loading status checks…
b677746

@bors bors closed this Dec 15, 2014

@bors bors merged commit 04b4b50 into rust-lang:master Dec 15, 2014
2 checks passed

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default all tests passed

@murarth murarth deleted the murarth:rusti-support branch Dec 15, 2014

@hastebrot hastebrot referenced this pull request Dec 16, 2014

Closed

implement a proper REPL #9898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.