Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Clone for PRNGs #20483
Conversation
rust-highfive
assigned
huonw
Jan 3, 2015
nagisa
changed the title
Rng copy
Implement Clone for PRNGs
Jan 3, 2015
nagisa
added some commits
Dec 23, 2014
nagisa
force-pushed the
nagisa:rng-copy
branch
from
10a5e0e
to
6ca1f0c
Jan 5, 2015
This comment has been minimized.
This comment has been minimized.
huonw
commented on 6ca1f0c
Jan 5, 2015
|
r+ |
This comment has been minimized.
This comment has been minimized.
huonw
replied
Jan 5, 2015
|
rollup |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 6, 2015
bors
merged commit 6ca1f0c
into
rust-lang:master
Jan 6, 2015
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nagisa commentedJan 3, 2015
CloneforChaChaRng,Isaac*Rng,StdRngandThreadRng;XorShiftRngCloneimplementation instead of implementing it explicitly.OsRngis the only Rng which does not implementCloneorCopyafter this patch because of its dependence onReader.r? @huonw I guess?