Skip to content

Conversation

@l0kod
Copy link
Contributor

@l0kod l0kod commented Jan 10, 2015

Revamp the AsRawFd implementations using generics.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@l0kod
Copy link
Contributor Author

l0kod commented Jan 10, 2015

The same thing could be done for Windows extension as well. I can do it (without testing) if interested.

cc @aturon

@alexcrichton
Copy link
Member

This unfortunately makes the implementors of AsRawFd impossible to find in the documentation itself because the AsInner trait does not show up in the documentation, and hence you're unable to find the total list of of all implementors.

@steveklabnik
Copy link
Contributor

This doesn't merge cleanly anymore, and will ned a rebase.

@l0kod
Copy link
Contributor Author

l0kod commented Feb 2, 2015

This unfortunately makes the implementors of AsRawFd impossible to find in the documentation itself because the AsInner trait does not show up in the documentation, and hence you're unable to find the total list of of all implementors.

Do I need to open an other issue for the documentation generation bug?

This doesn't merge cleanly anymore, and will ned a rebase.

Commit rebased.

@alexcrichton
Copy link
Member

Oh I'm sorry I actually meant to close this earlier. Unfortunately the documentation issue is not actually a bug but rather is a feature. Private traits like AsInner shouldn't be showing up in the documentation.

@l0kod l0kod deleted the asrawfd branch April 10, 2015 22:37
lnicola pushed a commit to lnicola/rust that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants