Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd foreach to IteratorExt #21098
Conversation
rust-highfive
assigned
nikomatsakis
Jan 13, 2015
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
This comment has been minimized.
This comment has been minimized.
|
As discussed on IRC, I think that an addition like this to a core library ultimately requires an RFC, so I'm going to close this PR for now. My own personal feeling is that a |
larroy commentedJan 13, 2015
Its a common idiom in other functional languages for side effects when chaining iterator functions