Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add foreach to IteratorExt #21098

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@larroy
Copy link

larroy commented Jan 13, 2015

Its a common idiom in other functional languages for side effects when chaining iterator functions

Pedro Larroy
Add foreach to IteratorExt, common idiom in other functional language…
…s for side effects when chaining iterator functions
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jan 13, 2015

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Jan 13, 2015

As discussed on IRC, I think that an addition like this to a core library ultimately requires an RFC, so I'm going to close this PR for now. My own personal feeling is that a for loop is a nice way to do side-effects, but I can certainly see the appeal of foreach as an alternative in some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.