Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace `0 as *const/mut T` with `ptr::null/null_mut()` #21444
Conversation
rust-highfive
assigned
brson
Jan 20, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Nice cleanup. Thanks. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 21, 2015
bors
merged commit 2c2480d
into
rust-lang:master
Jan 22, 2015
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
petrochenkov
deleted the
petrochenkov:null
branch
May 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
petrochenkov commentedJan 20, 2015
Motivation:
ptr::null/null_mut()are used more often in the codebase, they are more idiomatic0 as *const/mut Tisn't really a conversion and skews the conversion statisticsDrawbacks:
usedeclarations (but no new inter-crate dependencies)