Rollup of 10 pull requests #21556
Rollup of 10 pull requests #21556
Conversation
…e child panics before passing.
… directory's name, and remove the directory after a successful test.
Also makes errorck.py and tidy.py compatible with Python 3.
While trying to experiment with changes for some other issues, I noticed that the test for rust-lang#15149 was failing because I have `/tmp` mounted as `noexec` on my Linux box, and that test tries to run out of a temporary directory. This may not be the most common case, but it's not rare by any means, because executing from a world-writable directory is a security problem. (For this reason, some kernel options/mods such as grsecurity also can prevent this on Linux.) I instead copy the executable to a directory created in the build tree, following the example of the `process-spawn-with-unicode-params` test. After I made that change, I noticed that I'd made a mistake, but the test was still passing, because the "parent" process was not actually checking the status of the "child" process, meaning that the assertion in the child could never cause the overall test to fail. (I don't know if this has always been the case, or if it has something to do with either Windows or a change in the semantics of `spawn`.) So I fixed the test so that it would fail correctly, then fixed my original mistake so that it would pass again. The one big problem with this is that I haven't set up any machines of my own so that I can build on Windows, which is the platform this test was targeted at in the first place! That might take a while to address on my end. So I need someone else to check this on Windows.
…=alexcrichton Fix for `error: functions used as tests must have signature fn() -> ()` and `error: functions used as benches must have signature `fn(&mut Bencher) -> ()` in case of explicit return type declaration.
Fixes rust-lang#19759 I'm not going to bother to do more than this, as it'll end up getting re-done as part of the reference work, but at least it's correct now.
Also makes `errorck.py` and `tidy.py` compatible with Python 3.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ fef3b6d p=1 |
|
⌛ Testing commit fef3b6d with merge fc297e3... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry |
|
⌛ Testing commit fef3b6d with merge 540118d... |
|
💔 Test failed - auto-mac-64-opt |
|
@alexcrichton retry ? :/ |
|
@flaper87 The test failure is legit, so you should add a commit that addresses https://github.com/rust-lang/rust/pull/21529/files#r23487891 to this PR instead of just Or we can wait for @tshepang to resolve this issue. But in that case again, you should open a new rollup PR, so either way there needs to be some manual intervention. |
|
But I also think it would be better to open a new one anyways because we have three more PRs to roll up now... |
|
@barosl I have fixed the issue. Sorry for the pain :( |
|
@barosl oh mmh, it was late and I mistakenly assumed the issue was spurious because the job failing was the same. I'll re-open a new rollup. |
has_test_signature#21504, str: make replace() example more simple #21529, remove weird sentence #21532, Fix up lang items in the reference #21535, Makemake tidyPython scripts more idiomatic #21539, Language tweak in configure #21540, Check for make in configure #21541, Fix compile test for stage0 #21550