Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment about `UnsafeCell`s and `static` #21663

Merged
merged 2 commits into from Jan 29, 2015

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@tbu- @rust-highfive @alexcrichton @nikomatsakis @bors @steveklabnik
@tbu-
Copy link
Contributor

tbu- commented Jan 26, 2015

It has actually been safe to put an UnsafeCell into a non-mutable static
since the const change.

steveklabnik and others added some commits Jan 23, 2015

@steveklabnik
Improve libcore/cell.rs docs
Loading status checks…
edc6781
@tbu-
Remove comment about `UnsafeCell`s and `static` 
It has actually been safe to put an `UnsafeCell` into a non-mutable `static`
since the `const` change.
Loading status checks…
cbcb191

@rust-highfive rust-highfive assigned nikomatsakis Jan 26, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jan 26, 2015

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)
@tbu-

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

tbu- commented Jan 26, 2015

This is based on @steveklabnik unmerged pull request, because this would definitely conflict otherwise.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jan 27, 2015

@bors: r+ cbcb191 rollup

I think because they're the same commit that the merge should do the right thing (or so I hope!)

barosl added a commit to barosl/rust that referenced this pull request Jan 27, 2015

@barosl
Rollup merge of rust-lang#21663 - tbu-:pr_doc_cell_static_safety, r=a… 
…lexcrichton

It has actually been safe to put an `UnsafeCell` into a non-mutable `static`
since the `const` change.
50561f3

barosl added a commit to barosl/rust that referenced this pull request Jan 27, 2015

@barosl
Rollup merge of rust-lang#21663 - tbu-:pr_doc_cell_static_safety, r=a… 
…lexcrichton

It has actually been safe to put an `UnsafeCell` into a non-mutable `static`
since the `const` change.
4c49cab

barosl added a commit to barosl/rust that referenced this pull request Jan 27, 2015

@barosl
Rollup merge of rust-lang#21663 - tbu-:pr_doc_cell_static_safety, r=a… 
…lexcrichton

It has actually been safe to put an `UnsafeCell` into a non-mutable `static`
since the `const` change.
7e48d3c

barosl added a commit to barosl/rust that referenced this pull request Jan 27, 2015

@barosl
Rollup merge of rust-lang#21663 - tbu-:pr_doc_cell_static_safety, r=a… 
…lexcrichton

It has actually been safe to put an `UnsafeCell` into a non-mutable `static`
since the `const` change.
1e47b7d

barosl added a commit to barosl/rust that referenced this pull request Jan 27, 2015

@barosl
Rollup merge of rust-lang#21663 - tbu-:pr_doc_cell_static_safety, r=a… 
…lexcrichton

It has actually been safe to put an `UnsafeCell` into a non-mutable `static`
since the `const` change.
01271a7

@nikomatsakis nikomatsakis assigned alexcrichton and unassigned nikomatsakis Jan 28, 2015

@bors bors merged commit cbcb191 into rust-lang:master Jan 29, 2015
1 check passed

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.