Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPull configs out into individual repositories #21738
Conversation
rust-highfive
assigned
nikomatsakis
Jan 29, 2015
This comment has been minimized.
This comment has been minimized.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
steveklabnik
force-pushed the
steveklabnik:move_out_editors
branch
from
e50c3e7
to
017b3a5
Jan 29, 2015
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Are they still installed though? |
This comment has been minimized.
This comment has been minimized.
|
@tbu-: what do you mean, are they installed? If you mean what I think you mean, that’d be the job of packagers, not us (as it always has been, hasn’t it?). |
nikomatsakis
assigned
alexcrichton
and unassigned
nikomatsakis
Jan 29, 2015
This comment has been minimized.
This comment has been minimized.
|
@chris-morgan We're implicitely packagers too, with rustup.sh for example. |
This comment has been minimized.
This comment has been minimized.
|
@tbu-: rustup.sh works from the nightly builds, which don’t include these things. |
This comment has been minimized.
This comment has been minimized.
|
@chris-morgan We're packagers – not packaging things that were previously installed is a usability loss. If this becomes impossible to support once the editor files are moved out of the main repo, maybe that should be reconsidered instead? |
This comment has been minimized.
This comment has been minimized.
|
Lurking in, this seems like it's a going to devolve into bikeshedding pretty fast. However, in general the convention tends to be that:
In general though, moving them to a place that is more easily discovered should generally be considered a usability win, imo. As a trivial example, if you don't want to install your rusts system wide, you now have the option to install the editor plugins system wide, or to install them separately and not have your editor config depend on the arbitrary place you install rust to. my 2c, and I apologise in advance if this just makes the bikeshedding worse. |
This comment has been minimized.
This comment has been minimized.
|
@tbu-: I’m saying that I don’t believe we ever did install these things. |
This comment has been minimized.
This comment has been minimized.
|
As far as the Vim files are concerned, I intend to submit it upstream (into the Vim and Syntastic repositories) when Rust 1.0 is released. |
steveklabnik commentedJan 29, 2015
As we grow, these don't belong in-tree.
http://internals.rust-lang.org/t/moving-editor-highlighting-into-their-own-repos/1395