Allow methods that require Self:Sized to be object safe (RFC 817)
#22301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Ping? |
| // future, it would be.) But we know that the true `Self` DOES implement | ||
| // the trait. So we just delete this requirement. Hack hack hack. | ||
| let mut method_predicates = pick.method_ty.predicates.instantiate(self.tcx(), &all_substs); | ||
| match pick.kind { |
There was a problem hiding this comment.
It is weird to me that this code can just be plain deleted, was it serving no purpose?
…code that I've been longing to remove for quite some time.
nikomatsakis
force-pushed
the
object-safe-sized-methods
branch
from
e8f1b15 to
fd9f7da
Compare
|
@huonw that code was serving a purpose when |
|
@huonw just rebased and added the code about by-value-self, should be ready for r? now |
|
@bors r+ fd9f |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2015
…ods, r=huonw RFC 817 is not yet accepted, but I wanted to put this code up so people can see how it works. And to be ready lest it should be accepted. cc rust-lang/rfcs#817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 817 is not yet accepted, but I wanted to put this code up so people can see how it works. And to be ready lest it should be accepted.
cc rust-lang/rfcs#817