Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow methods that require `Self:Sized` to be object safe (RFC 817) #22301
Conversation
rust-highfive
assigned
huonw
Feb 13, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
nikomatsakis
referenced this pull request
Feb 13, 2015
Merged
Tweaks to the object-safety rules #817
This comment has been minimized.
This comment has been minimized.
|
Ping? |
huonw
reviewed
Feb 21, 2015
| // future, it would be.) But we know that the true `Self` DOES implement | ||
| // the trait. So we just delete this requirement. Hack hack hack. | ||
| let mut method_predicates = pick.method_ty.predicates.instantiate(self.tcx(), &all_substs); | ||
| match pick.kind { |
This comment has been minimized.
This comment has been minimized.
huonw
Feb 21, 2015
Member
It is weird to me that this code can just be plain deleted, was it serving no purpose?
nikomatsakis
added some commits
Feb 9, 2015
nikomatsakis
force-pushed the
nikomatsakis:object-safe-sized-methods
branch
from
e8f1b15
to
fd9f7da
Feb 23, 2015
This comment has been minimized.
This comment has been minimized.
|
@huonw that code was serving a purpose when |
This comment has been minimized.
This comment has been minimized.
|
@huonw just rebased and added the code about by-value-self, should be ready for r? now |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ fd9f |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2015
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2015
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2015
bors
merged commit fd9f7da
into
rust-lang:master
Feb 24, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
nikomatsakis
deleted the
nikomatsakis:object-safe-sized-methods
branch
Mar 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nikomatsakis commentedFeb 13, 2015
RFC 817 is not yet accepted, but I wanted to put this code up so people can see how it works. And to be ready lest it should be accepted.
cc rust-lang/rfcs#817