Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction concurrent examples aren't actually concurrent #23202

Merged
merged 2 commits into from Mar 9, 2015

Conversation

Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@shepmaster @rust-highfive @steveklabnik @brson @bors
@shepmaster
Copy link
Member

shepmaster commented Mar 8, 2015

If we end the scoped call with a semicolon, the JoinGuard will be
dropped and not returned from the map. The thread will start up and
we immediately block, making for a very expensive sequential loop.

shepmaster added some commits Mar 8, 2015

@shepmaster
Update example that uses deprecated Thread::scoped
a6ebd26
@shepmaster
Make concurrent examples actually run concurrently 
If we end the `scoped` call with a semicolon, the `JoinGuard` will be
dropped and not returned from the `map`. The thread will start up and
we immediately block, making for a very expensive sequential loop.
Loading status checks…
b426a24

@rust-highfive rust-highfive assigned brson Mar 8, 2015

@shepmaster

This comment has been minimized.

Sign in to view
Copy link
Member Author

shepmaster commented Mar 8, 2015

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned brson Mar 8, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Mar 8, 2015

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)
@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member

steveklabnik commented Mar 8, 2015

@bors: r+ b426a24 Rollup
@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member

steveklabnik commented Mar 9, 2015

@bors: rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 9, 2015

@Manishearth
Rollup merge of rust-lang#23202 - shepmaster:intro-threads-not-concur… 
…rent, r=steveklabnik

 If we end the `scoped` call with a semicolon, the `JoinGuard` will be
dropped and not returned from the `map`. The thread will start up and
we immediately block, making for a very expensive sequential loop.
f8ff828

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 9, 2015

@Manishearth
Rollup merge of rust-lang#23202 - shepmaster:intro-threads-not-concur… 
…rent, r=steveklabnik

 If we end the `scoped` call with a semicolon, the `JoinGuard` will be
dropped and not returned from the `map`. The thread will start up and
we immediately block, making for a very expensive sequential loop.
894cd39

@bors bors merged commit b426a24 into rust-lang:master Mar 9, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shepmaster shepmaster deleted the shepmaster:intro-threads-not-concurrent branch Mar 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.