Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upChange the trivial cast lints to allow by default #23776
Conversation
rust-highfive
assigned
alexcrichton
Mar 27, 2015
petrochenkov
reviewed
Mar 27, 2015
| @@ -102,13 +102,13 @@ declare_lint! { | |||
|
|
|||
| declare_lint! { | |||
| pub TRIVIAL_CASTS, | |||
| Warn, | |||
| Allow, | |||
This comment has been minimized.
This comment has been minimized.
petrochenkov
Mar 27, 2015
Contributor
Should this stay "Warn"? People asked only for allowing numeric casts.
This comment has been minimized.
This comment has been minimized.
nrc
Mar 27, 2015
Author
Member
We decided we would make the trivial cast lint Allow too until type ascription lands.
This comment has been minimized.
This comment has been minimized.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 27, 2015
bors
merged commit a67faf1
into
rust-lang:master
Mar 28, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nrc commentedMar 27, 2015
r? @alexcrichton