Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upconvert: remove FromError, use From<E> instead #23879
Conversation
rust-highfive
assigned
alexcrichton
Mar 31, 2015
This comment has been minimized.
This comment has been minimized.
|
I'm still building the tests, but I fixed each instance that showed up with grep. |
This comment has been minimized.
This comment has been minimized.
|
Erg, this is hitting coherence errors. I can't have |
This comment has been minimized.
This comment has been minimized.
|
I'm working on resolving that with #23875 I previously hadn't deprecated |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
This sounds like a great idea to me! I'm all for it (although I'd land it either after or in tandem with #23875) |
This comment has been minimized.
This comment has been minimized.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 31, 2015
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 31, 2015
bors
merged commit e17f4fc
into
rust-lang:master
Apr 1, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
andersk
added a commit
to andersk/byteorder-rs
that referenced
this pull request
Apr 2, 2015
andersk
added a commit
to andersk/rustc-serialize-rs
that referenced
this pull request
Apr 2, 2015
andersk
added a commit
to andersk/num-rs
that referenced
this pull request
Apr 2, 2015
andersk
added a commit
to andersk/image-rs
that referenced
this pull request
Apr 2, 2015
gbersac
added a commit
to gbersac/rustc-serialize
that referenced
this pull request
May 8, 2015
gbersac
added a commit
to gbersac/rustc-serialize
that referenced
this pull request
May 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
seanmonstar commentedMar 31, 2015
This removes the FromError trait, since it can now be expressed using
the new convert::Into trait. All implementations of FromError where
changed to From, and
try!was changed to use From::from instead.Because this removes FromError, it is a breaking change, but fixing it
simply requires changing the words
FromErrortoFrom, andfrom_errortofrom.[breaking-change]
r? @alexcrichton or @aturon