Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upstd: Changing the meaning of the count to splitn #23951
Conversation
rust-highfive
assigned
pcwalton
Apr 1, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
r? @aturon |
rust-highfive
assigned
aturon
and unassigned
pcwalton
Apr 1, 2015
This comment has been minimized.
This comment has been minimized.
|
Can you add documentation saying that the last element returned, if any, contains the remainder of the data? Otherwise r=me |
alexcrichton
force-pushed the
alexcrichton:splitn
branch
from
cf435e4
to
e98dce3
Apr 1, 2015
This comment has been minimized.
This comment has been minimized.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 1, 2015
alexcrichton
merged commit e98dce3
into
rust-lang:master
Apr 2, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
alexcrichton
deleted the
alexcrichton:splitn
branch
Apr 2, 2015
This comment has been minimized.
This comment has been minimized.
|
Uh. I wish this had also included a change that breaks at compile time, like renaming the function or something. As it is, it seems likely to cause silent breakage. |
This comment has been minimized.
This comment has been minimized.
|
Yep, this siliently bit me. Thankfully I had tests, but it was quite confusing. |
This comment has been minimized.
This comment has been minimized.
|
@SimonSapin @seanmonstar Yes, this was an unfortunate rush, and I apologize for the inconvenience. |
SimonSapin
referenced this pull request
May 5, 2015
Merged
RFC: Policy on semver and API evolution #1105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedApr 1, 2015
This commit is an implementation of RFC 979 which changes the meaning of
the count parameter to the
splitnfunction on strings and slices. Theparameter now means the number of items that are returned from the iterator, not
the number of splits that are made.
Closes #23911
[breaking-change]