Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully optimize by default #24205

Closed
wants to merge 12 commits into from

Conversation

Reviewers
No reviews
Assignees

@huonw huonw

Labels
None yet
Projects
None yet
Milestone
No milestone
8 participants
@brson @rust-highfive @nrc @alexcrichton @bors @nagisa @pnkfelix @huonw
@brson
Copy link
Contributor

brson commented Apr 8, 2015

This makes the default configuration fully optimized, with no debugging options, no llvm asserts, renames --enable-debug to --enable-debug-assertions, and adds --enable-debug as a blanket option that toggles various things, per #17665. It does not add a --enable-release flag since that would be a no-op.

cc @nrc

Fixes #22390
Fixes #17081
Partially addresses #17665

@rust-highfive rust-highfive assigned huonw Apr 8, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Apr 8, 2015

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)
@nrc

This comment has been minimized.

Sign in to view
Copy link
Member

nrc commented Apr 8, 2015

Could we build jemalloc with --enable-debug and --enable-fill in the debug configuration? Otherwise, looks good!
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Apr 8, 2015

@nrc done
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Apr 8, 2015

@bors: r+ 6d17c35
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Apr 8, 2015

For some reason when I build with --enable-debug, llvm-mc doesn't get built.
@brson
Don't deoptimize llvm when --enable-debug 
libLTO fails to link here.
Loading status checks…
a725426
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Apr 9, 2015

I pushed a follow up that changes --enable-debug to not set --disable-optimize-llvm since I cannot get LLVM to build (libLTO linking fails) in that config.
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Apr 9, 2015

@bors r=alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 9, 2015

📌 Commit a725426 has been approved by alexcrichton

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 9, 2015

@Manishearth
Rollup merge of rust-lang#24205 - brson:debug, r=alexcrichton 
 This makes the default configuration fully optimized, with no debugging options, no llvm asserts, renames --enable-debug to --enable-debug-assertions, and adds --enable-debug as a blanket option that toggles various things, per rust-lang#17665. It does not add a `--enable-release` flag since that would be a no-op.

cc @nrc

Fixes rust-lang#22390
Fixes rust-lang#17081
Partially addresses rust-lang#17665
b43c957
@nagisa

This comment has been minimized.

Sign in to view
Copy link
Contributor

nagisa commented Apr 9, 2015

I still disagree with disabling LLVM asserts in nightlies.
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Apr 9, 2015

@nagisa Oh, I did mean to leave llvm asserts on for nightlies. I'll update it.
@brson
Nightly gets LLVM assertions
Loading status checks…
0e0c841
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Apr 9, 2015

@bors a=alexcrichton

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 9, 2015

@Manishearth
Rollup merge of rust-lang#24205 - brson:debug, r=alexcrichton 
 This makes the default configuration fully optimized, with no debugging options, no llvm asserts, renames --enable-debug to --enable-debug-assertions, and adds --enable-debug as a blanket option that toggles various things, per rust-lang#17665. It does not add a `--enable-release` flag since that would be a no-op.

cc @nrc

Fixes rust-lang#22390
Fixes rust-lang#17081
Partially addresses rust-lang#17665
2dffe78
@nagisa

This comment has been minimized.

Sign in to view
Copy link
Contributor

nagisa commented Apr 9, 2015

@brson yay!
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Apr 9, 2015

@bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 9, 2015

📌 Commit 0e0c841 has been approved by alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 9, 2015

⌛️ Testing commit 0e0c841 with merge 6b95d8b...

bors added a commit that referenced this pull request Apr 9, 2015

@bors
Auto merge of #24205 - brson:debug, r=alexcrichton 
This makes the default configuration fully optimized, with no debugging options, no llvm asserts, renames --enable-debug to --enable-debug-assertions, and adds --enable-debug as a blanket option that toggles various things, per #17665. It does not add a `--enable-release` flag since that would be a no-op.

cc @nrc

Fixes #22390
Fixes #17081
Partially addresses #17665
Loading status checks…
6b95d8b
@bors
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Apr 10, 2015

This... was merged? Not sure what github is doing... Closing!

@alexcrichton alexcrichton closed this Apr 10, 2015

@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Apr 14, 2015

Ah ha! I bet this is why my make rustc-stage1 lately have been taking 40 minutes or more!

Filed #24405

This was referenced Apr 26, 2015

Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.