Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more deprecated functionality #24636

Merged
merged 5 commits into from Apr 22, 2015

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
beta-accepted
Projects
None yet
Milestone
No milestone
6 participants
@alexcrichton @rust-highfive @brson @bors @pnkfelix @tamird
@alexcrichton
Copy link
Member

alexcrichton commented Apr 20, 2015

This removes a large amount of deprecated functionality (pre-1.0 beta). Mostly this cleans up std::num.

@rust-highfive rust-highfive assigned brson Apr 20, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Apr 20, 2015

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson brson added the beta-nominated label Apr 20, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Apr 20, 2015

I tagged this with 'beta' so we don't forget this needs to go in.
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Apr 20, 2015

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 20, 2015

📌 Commit cdaf880 has been approved by brson
src/libcoretest/num/mod.rs Outdated
assert_eq!(s, None);
let f : Option<f32> = from_str_radix("10000000000000000000000000000000000000000", 10).ok();
let f : Option<f32> = f32::from_str_radix("10000000000000000000000000000000000000000", 10).ok();

This comment has been minimized.

Sign in to view
Copy link
@tamird

tamird Apr 20, 2015

Contributor

this failed tidy
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 21, 2015

☔️ The latest upstream changes (presumably #24648) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the alexcrichton:remove-deprecated branch 2 times, most recently from c1da532 to 92369da Apr 21, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 21, 2015

@bors: r=brson 92369da p=1

bors added a commit that referenced this pull request Apr 21, 2015

@bors
Auto merge of #24636 - alexcrichton:remove-deprecated, r=brson 
This removes a large amount of deprecated functionality (pre-1.0 beta). Mostly this cleans up `std::num`.
1860461
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 21, 2015

⌛️ Testing commit 92369da with merge 1860461...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 21, 2015

💔 Test failed - auto-linux-32-opt
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 21, 2015

☔️ The latest upstream changes (presumably #24620) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton added some commits Apr 17, 2015

@alexcrichton
std: Remove deprecated AsOsStr/Str/AsSlice traits 
Cleaning out more deprecated items
69ded69
@alexcrichton
std: Remove deprecated AsPath trait
e091ba3
@alexcrichton
std: Remove deprecated/unstable num functionality 
This commit removes all the old casting/generic traits from `std::num` that are
no longer in use by the standard library. This additionally removes the old
`strconv` module which has not seen much use in quite a long time. All generic
functionality has been supplanted with traits in the `num` crate and the
`strconv` module is supplanted with the [rust-strconv crate][rust-strconv].

[rust-strconv]: https://github.com/lifthrasiir/rust-strconv

This is a breaking change due to the removal of these deprecated crates, and the
alternative crates are listed above.

[breaking-change]
eeb9488
@alexcrichton
test: Fix fallout in tests
0791f9f

@alexcrichton alexcrichton force-pushed the alexcrichton:remove-deprecated branch 2 times, most recently from 3e5a4af to 41dddce Apr 21, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 21, 2015

@bors: r=brson 41dddce

bors added a commit that referenced this pull request Apr 21, 2015

@bors
Auto merge of #24636 - alexcrichton:remove-deprecated, r=brson 
This removes a large amount of deprecated functionality (pre-1.0 beta). Mostly this cleans up `std::num`.
db958b7
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 21, 2015

⌛️ Testing commit 41dddce with merge db958b7...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 21, 2015

💔 Test failed - auto-win-64-nopt-t

@alexcrichton alexcrichton force-pushed the alexcrichton:remove-deprecated branch from 41dddce to 1a10133 Apr 21, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 21, 2015

@bors: r+

On Tue, Apr 21, 2015 at 12:54 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/3105

—
Reply to this email directly or view it on GitHub
#24636 (comment).
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 21, 2015

📌 Commit 1a10133 has been approved by alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 21, 2015

⌛️ Testing commit 1a10133 with merge 09e67cf...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 21, 2015

💔 Test failed - auto-win-64-nopt-t

@alexcrichton alexcrichton force-pushed the alexcrichton:remove-deprecated branch from 1a10133 to 028aaaa Apr 21, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 21, 2015

@bors: r+ 028aaaa

@alexcrichton alexcrichton force-pushed the alexcrichton:remove-deprecated branch 2 times, most recently from 8f0650e to 1a19c78 Apr 21, 2015

@alexcrichton
std: Bring back f32::from_str_radix as an unstable API 
This API was exercised in a few tests and mirrors the `from_str_radix`
functionality of the integer types.
Loading status checks…
a568a7f

@alexcrichton alexcrichton force-pushed the alexcrichton:remove-deprecated branch from 1a19c78 to a568a7f Apr 21, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 21, 2015

@bors: r+ a568a7f

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 21, 2015

@alexcrichton
rollup merge of rust-lang#24636: alexcrichton/remove-deprecated 
Conflicts:
	src/libcore/result.rs
a1dd5ac

@bors bors merged commit a568a7f into rust-lang:master Apr 22, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

This was referenced Apr 22, 2015

Closed
Merged
@pnkfelix

This comment has been minimized.

Sign in to view
Copy link
Member

pnkfelix commented Apr 23, 2015

going from nominated to (nominated, accepted)

@pnkfelix pnkfelix added the beta-accepted label Apr 23, 2015

@alexcrichton alexcrichton removed the beta-nominated label Apr 23, 2015

@alexcrichton alexcrichton deleted the alexcrichton:remove-deprecated branch Apr 30, 2015

@cuviper cuviper referenced this pull request Dec 21, 2017

Open

Add rsqrt method to Float trait #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.