Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMention --enable-optimize for --enable-debug #24902
Conversation
rust-highfive
assigned
nikomatsakis
Apr 28, 2015
This comment has been minimized.
This comment has been minimized.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
bombless
force-pushed the
bombless:configure
branch
from
cfcf000
to
db0abc9
Apr 28, 2015
bombless
changed the title
Mention --enable-optimized for --enable-debug
Mention --enable-optimize for --enable-debug
Apr 28, 2015
This comment has been minimized.
This comment has been minimized.
|
Update: Moved content/rant to https://internals.rust-lang.org/t/why-is-enable-debug-implying-disable-optimize-for-rustc/1978 Sorry for the attempted hijack of the comment thread. |
This comment has been minimized.
This comment has been minimized.
|
(Arguably I really should not be using github comments for this argument and hijacking a well-meaning pull request like this, which is certainly an improvement over the status quo. I'll copy the above comment to an internals post instead.) |
pnkfelix
reviewed
Apr 30, 2015
| @@ -544,7 +544,7 @@ fi | |||
| BOOL_OPTIONS="" | |||
| VAL_OPTIONS="" | |||
|
|
|||
| opt debug 0 "debug mode" | |||
| opt debug 0 "debug mode; you may also want extra --enable-optimize for this as it disable optimization by default" | |||
This comment has been minimized.
This comment has been minimized.
pnkfelix
Apr 30, 2015
Member
First, grammatical typo: "as it disable optimization by default" is not correct. perhaps you meant "... it disables ..." ?
Second: Its pretty long; it gets out to column 114 in my editor, and so it will pretty long in the users terminal. I'm not sure if we have other help text for configure that is so long on one line.
Third: the word "it" in the output is slightly ambiguous; a naive user might think that the word "it" there refers to the --enable-optimize option. (Yes, i know that would be a silly interpretation.)
Maybe better text would be just:
"debug mode; disables optimization unless `--enable-optimize` given"
bombless
force-pushed the
bombless:configure
branch
from
db0abc9
to
98b7aaf
Apr 30, 2015
This comment has been minimized.
This comment has been minimized.
|
@pnkfelix , thanks for your patience :) |
bombless commentedApr 28, 2015
Closes #24840