Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention --enable-optimize for --enable-debug #24902

Merged
merged 1 commit into from Apr 30, 2015

Conversation

Projects
None yet
5 participants
@bombless
Copy link
Contributor

bombless commented Apr 28, 2015

Closes #24840

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Apr 28, 2015

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@bombless bombless force-pushed the bombless:configure branch from cfcf000 to db0abc9 Apr 28, 2015

@bombless bombless changed the title Mention --enable-optimized for --enable-debug Mention --enable-optimize for --enable-debug Apr 28, 2015

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Apr 29, 2015

Update: Moved content/rant to https://internals.rust-lang.org/t/why-is-enable-debug-implying-disable-optimize-for-rustc/1978

Sorry for the attempted hijack of the comment thread.

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Apr 29, 2015

(Arguably I really should not be using github comments for this argument and hijacking a well-meaning pull request like this, which is certainly an improvement over the status quo. I'll copy the above comment to an internals post instead.)

configure Outdated
@@ -544,7 +544,7 @@ fi
BOOL_OPTIONS=""
VAL_OPTIONS=""

opt debug 0 "debug mode"
opt debug 0 "debug mode; you may also want extra --enable-optimize for this as it disable optimization by default"

This comment has been minimized.

@pnkfelix

pnkfelix Apr 30, 2015

Member

First, grammatical typo: "as it disable optimization by default" is not correct. perhaps you meant "... it disables ..." ?

Second: Its pretty long; it gets out to column 114 in my editor, and so it will pretty long in the users terminal. I'm not sure if we have other help text for configure that is so long on one line.

Third: the word "it" in the output is slightly ambiguous; a naive user might think that the word "it" there refers to the --enable-optimize option. (Yes, i know that would be a silly interpretation.)

Maybe better text would be just:

"debug mode; disables optimization unless `--enable-optimize` given"

@bombless bombless force-pushed the bombless:configure branch from db0abc9 to 98b7aaf Apr 30, 2015

@bombless

This comment has been minimized.

Copy link
Contributor Author

bombless commented Apr 30, 2015

@pnkfelix , thanks for your patience :)

@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Apr 30, 2015

@bors r+ 98b7aaf rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Apr 30, 2015

⌛️ Testing commit 98b7aaf with merge 2f613bf...

bors added a commit that referenced this pull request Apr 30, 2015

@bors bors merged commit 98b7aaf into rust-lang:master Apr 30, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.