std: Destabilize io::BufStream #25009
Conversation
As pointed out in rust-lang#17136 the semantics of a `BufStream` aren't always what one expects, and it looks like other [languages like C#][c-sharp] implement a buffered stream with only one underlying buffer. For now this commit destabilizes the primitive in the `std::io` module to give us some more time in figuring out what to do with it. [c-sharp]: https://msdn.microsoft.com/en-us/library/system.io.bufferedstream%28v=vs.110%29.aspx [breaking-change]
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @aturon |
alexcrichton
added
the
beta-nominated
|
cc @sfackler |
|
I will also publish a crate for |
|
I mean, rust-postgres is going to need a buffered stream or it'll slow down by one or two orders of magnitude. |
|
@sfackler yeah this is definitely not suggesting the primitive is not useful, we're just unclear that having two buffers is the right semantics for this to have. |
|
@bors: r+ p=10 (breaking change) |
|
📌 Commit db477ee has been approved by |
|
⌛ Testing commit db477ee with merge eae692e... |
As pointed out in #17136 the semantics of a `BufStream` aren't always what one expects, and it looks like other [languages like C#][c-sharp] implement a buffered stream with only one underlying buffer. For now this commit destabilizes the primitive in the `std::io` module to give us some more time in figuring out what to do with it. [c-sharp]: https://msdn.microsoft.com/en-us/library/system.io.bufferedstream%28v=vs.110%29.aspx [breaking-change]
|
💔 Test failed - auto-linux-32-opt |
|
@bors retry |
|
⚡ Previous build results for auto-mac-64-nopt-t, auto-mac-64-opt are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt... |
alexcrichton
added
the
beta-accepted
brson
removed
the
beta-nominated
As pointed out in #17136 the semantics of a
BufStreamaren't always what oneexpects, and it looks like other languages like C# implement a
buffered stream with only one underlying buffer. For now this commit
destabilizes the primitive in the
std::iomodule to give us some more time infiguring out what to do with it.
[breaking-change]