Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd macro lifetime specifier #25509
Conversation
rust-highfive
assigned
huonw
May 16, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
Diggsey
force-pushed the
Diggsey:issue-23956
branch
from
68c41a1
to
2e91fb8
May 16, 2015
This comment has been minimized.
This comment has been minimized.
|
One point of possible worry is that |
Diggsey
force-pushed the
Diggsey:issue-23956
branch
from
2e91fb8
to
9b0be24
May 18, 2015
This comment has been minimized.
This comment has been minimized.
|
I renamed it to use "life" instead of "lifetime" to avoid the conflict. |
This comment has been minimized.
This comment has been minimized.
|
Bump? @huonw |
This comment has been minimized.
This comment has been minimized.
|
Hm, I think this needs a few more pairs of eyes. |
huonw
added
I-nominated
T-lang
labels
Jun 17, 2015
This comment has been minimized.
This comment has been minimized.
|
Seems like an RFC would make sense to work out naming etc. But also, this should be feature-gated. |
This comment has been minimized.
This comment has been minimized.
|
During lang subteam mtg, we decided this should have an RFC, since it is a language extension, albeit a minor one. Removing nomination since we've taken a look (no priority needed). |
nikomatsakis
removed
the
I-nominated
label
Jul 23, 2015
HeroesGrave
referenced this pull request
Jul 25, 2015
Open
Can't pass in borrowed data to systems #24
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@Diggsey any interest in pursuing an RFC for this, like @nikomatsakis suggested? |
This comment has been minimized.
This comment has been minimized.
|
I'd be interested in helping with an RFC for this. |
This comment has been minimized.
This comment has been minimized.
|
It occurs to me that adding a fragment specifier for lifetimes doesn't actually fix significant situations where you might want to parse a lifetime specifier, for example in a list of generic parameters. In such a situation you would have to differentiate a lifetime specifier from an identifier, and in general a macro can't alternate on one fragment specifier vs another, unless this is actually a bug (cf #27832). A design which could allow such alternation is not a new fragment specifier, but a (hopefully minor) modification to the lexer to allow |
This comment has been minimized.
This comment has been minimized.
|
Closing due to inactivity (and sounds like an RFC is desired) |
Diggsey commentedMay 16, 2015
Allows accepting a lifetime as a parameter to a macro.
Fixes #23956