Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Reexport std::net::tcp::Incoming #25522

Merged
merged 1 commit into from May 17, 2015

Conversation

Reviewers
No reviews
Assignees

@aturon aturon

Labels
T-libs beta-accepted
Projects
None yet
Milestone
No milestone
6 participants
@alexcrichton @rust-highfive @sfackler @brson @aturon @bors
@alexcrichton
Copy link
Member

alexcrichton commented May 17, 2015

This iterator was mistakenly not reexported at the top level, preventing
actually naming the type!

Closes #25519
@alexcrichton
std: Reexport std::net::tcp::Incoming 
This iterator was mistakenly not reexported at the top level, preventing
actually naming the type!

Closes #25519
Loading status checks…
e5e722b

@alexcrichton alexcrichton added the beta-nominated label May 17, 2015

@rust-highfive rust-highfive assigned brson May 17, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented May 17, 2015

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned brson May 17, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented May 17, 2015

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)
@sfackler

This comment has been minimized.

Sign in to view
Copy link
Member

sfackler commented May 17, 2015

@bors r+ e5e722b rollup

Why didn't this hit the private-types-in-public-APIs check?

Manishearth added a commit to Manishearth/rust that referenced this pull request May 17, 2015

@Manishearth
Rollup merge of rust-lang#25522 - alexcrichton:reexport-incoming, r=s… 
…fackler

This iterator was mistakenly not reexported at the top level, preventing
actually naming the type!

Closes rust-lang#25519
a0815c8

@Manishearth Manishearth referenced this pull request May 17, 2015

Merged

Rollup of 14 pull requests #25525

bors added a commit that referenced this pull request May 17, 2015

@bors
Auto merge of #25525 - Manishearth:rollup, r=Manishearth 
- Successful merges: #25465, #25469, #25472, #25474, #25476, #25484, #25490, #25493, #25503, #25506, #25508, #25510, #25516, #25522
- Failed merges:
Loading status checks…
9f3a7f0

@bors bors merged commit e5e722b into rust-lang:master May 17, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexcrichton alexcrichton deleted the alexcrichton:reexport-incoming branch May 19, 2015

@alexcrichton alexcrichton added the T-libs label May 28, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jun 9, 2015

triage: beta-accepted

@alexcrichton alexcrichton added the beta-accepted label Jun 9, 2015

@alexcrichton alexcrichton referenced this pull request Jun 10, 2015

Merged

Backport accepted PRs to beta #26161

@alexcrichton alexcrichton removed the beta-nominated label Jun 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.