Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax: Remove unused `packed` attribute #25541

Merged
merged 1 commit into from May 18, 2015

Conversation

Projects
None yet
5 participants
@klutzy
Copy link
Contributor

klutzy commented May 17, 2015

The attribute was removed by #16499.

syntax: Remove unused `packed` attribute
The attribute was removed by #16499.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented May 17, 2015

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented May 17, 2015

Hm, so technically this is a breaking change as any existing #[packed] attributes will start to be an error instead of being silently ignored, but I believe that this falls under the "easy fix" purview of rust-lang/rfcs#1105, so I think that this is fine to go through.

@bors: r+ d0fc35f

@klutzy

This comment has been minimized.

Copy link
Contributor Author

klutzy commented May 18, 2015

Yep, I think this is the case of "Minor change: introducing new lint warnings/errors" of the RFC. This patch was made since a Rust beginner misused #[packed] but compiler didn't make a warning.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 18, 2015

⌛️ Testing commit d0fc35f with merge 8a8583c...

bors added a commit that referenced this pull request May 18, 2015

@bors bors merged commit d0fc35f into rust-lang:master May 18, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@klutzy klutzy deleted the klutzy:remove-packed-attr branch May 18, 2015

@Liamsi Liamsi referenced this pull request Jun 13, 2015

Closed

Fix QVariant enum #16

Liamsi added a commit to Liamsi/qmlrs that referenced this pull request Jun 13, 2015

@brson

This comment has been minimized.

Copy link
Contributor

brson commented Jul 13, 2015

As mentioned here this causes stable regressions with crates that were using the #[packed] attribute.

steveklabnik added a commit to steveklabnik/libnetfilter_queue that referenced this pull request Jul 21, 2015

AnIrishDuck added a commit to AnIrishDuck/rusty-prism that referenced this pull request Nov 13, 2015

fsck added a commit to fsck/libnetfilter_queue that referenced this pull request Oct 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.