Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMake debug builders take &mut self, add entries method #25548
Conversation
rust-highfive
assigned
huonw
May 17, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
rust-highfive
assigned
alexcrichton
and unassigned
huonw
May 17, 2015
sfackler
force-pushed the
sfackler:debug-builders-by-ref
branch
from
6920567
to
bd85983
May 18, 2015
liigo
reviewed
May 18, 2015
src/libcore/fmt/builders.rs
Outdated
| } | ||
| self | ||
| } | ||
|
|
||
| /// Consumes the `DebugSet`, finishing output and returning any error |
This comment has been minimized.
This comment has been minimized.
liigo
reviewed
May 18, 2015
src/libcore/fmt/builders.rs
Outdated
| @@ -96,7 +96,7 @@ impl<'a, 'b: 'a> DebugStruct<'a, 'b> { | |||
| /// Consumes the `DebugStruct`, finishing output and returning any error | |||
This comment has been minimized.
This comment has been minimized.
liigo
reviewed
May 18, 2015
src/libcore/fmt/builders.rs
Outdated
| @@ -159,7 +159,7 @@ impl<'a, 'b: 'a> DebugTuple<'a, 'b> { | |||
| /// Consumes the `DebugTuple`, finishing output and returning any error | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Fixed, thanks |
alexcrichton
reviewed
May 18, 2015
| for entry in entries { | ||
| self.entry(&entry); | ||
| } | ||
| self |
This comment has been minimized.
This comment has been minimized.
alexcrichton
May 18, 2015
Member
This could probably even be entries.into_iter().fold(self, |me, a| me.entry(a)), but that's getting somewhat complicated!
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
May 18, 2015
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
May 19, 2015
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
merged commit e87b353
into
rust-lang:master
May 19, 2015
sfackler
deleted the
sfackler:debug-builders-by-ref
branch
Nov 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
sfackler commentedMay 17, 2015
Based on feedback from https://internals.rust-lang.org/t/final-comment-period-for-debug-builders-stabilization/2007/2