Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSimplify `core::num` using `Self` #25687
Conversation
tamird
added some commits
May 21, 2015
rust-highfive
assigned
alexcrichton
May 21, 2015
This comment has been minimized.
This comment has been minimized.
|
alex's on vacation |
Gankro
assigned
Gankro
and unassigned
alexcrichton
May 21, 2015
This comment has been minimized.
This comment has been minimized.
|
Awesome! @bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
Gankro
referenced this pull request
May 21, 2015
Closed
Use associated constants in `std::num::{Zero,One}` #25684
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 22, 2015
bors
added a commit
that referenced
this pull request
May 23, 2015
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
bors
added a commit
that referenced
this pull request
May 23, 2015
bors
merged commit cf11c26
into
rust-lang:master
May 23, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
tamird
deleted the
tamird:num-self-cleanup
branch
May 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tamird commentedMay 21, 2015
Cleanup extracted from #25684. r? @alexcrichton