Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register snapshots (2015-05-24 ba0e1cd). #25790

Merged
merged 3 commits into from May 27, 2015

Conversation

Projects
None yet
6 participants
@eddyb
Copy link
Member

eddyb commented May 26, 2015

No description provided.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented May 26, 2015

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb eddyb force-pushed the eddyb:oh-snap-ctfe-arrived branch from 203e101 to a085f4a May 26, 2015

@eddyb eddyb changed the title [DO NOT MERGE] Register snapshots (2015-05-24 ba0e1cd). Register snapshots (2015-05-24 ba0e1cd). May 26, 2015

@eddyb eddyb force-pushed the eddyb:oh-snap-ctfe-arrived branch from a085f4a to 7eee86a May 26, 2015

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented May 26, 2015

Yay! Is this still blocked on anything @eddyb? I'd also like to get this in to get MSVC bootstrapping itself.

We've retroactively registered bitrig snapshots in the past, so we don't necessarily need to block on those becoming available.

@dhuseby

This comment has been minimized.

Copy link

dhuseby commented May 26, 2015

My builder is back up and running now that I fixed the VM config. If we hold off for a few hours, we'll have a bitrig stage 3 snap to include.

@eddyb

This comment has been minimized.

Copy link
Member Author

eddyb commented May 26, 2015

@dhardy the same build that failed twice, right? It would be nice for it to be the same revision.
@alexcrichton if you're okay with the zeroed hash and replacing it later (with a snapshot built from that same revision), feel free to r+.

@dhuseby

This comment has been minimized.

Copy link

dhuseby commented May 26, 2015

@eddyb the snapshot at that revision is now building: http://buildbot.rust-lang.org/builders/snap3-bitrig-64/builds/124

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented May 26, 2015

I'll throw this onto bors for now just to get it in the queue (may weed out some errors), and we can always pull in the bitrig snapshots once they're ready!

@bors: r+ 7eee86a

@eddyb eddyb force-pushed the eddyb:oh-snap-ctfe-arrived branch from 7eee86a to b368f7f May 26, 2015

@eddyb

This comment has been minimized.

Copy link
Member Author

eddyb commented May 26, 2015

@bors r=alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 26, 2015

📌 Commit b368f7f has been approved by alexcrichton

bors added a commit that referenced this pull request May 27, 2015

@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 27, 2015

⌛️ Testing commit b368f7f with merge 7d71f50...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 27, 2015

💔 Test failed - auto-mac-64-opt

@eddyb

This comment has been minimized.

Copy link
Member Author

eddyb commented May 27, 2015

@dhuseby Thanks for the fixing bitrig, seems we have a snapshot.

@eddyb eddyb force-pushed the eddyb:oh-snap-ctfe-arrived branch from b368f7f to 377b090 May 27, 2015

@eddyb

This comment has been minimized.

Copy link
Member Author

eddyb commented May 27, 2015

@bors r=alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 27, 2015

📌 Commit 377b090 has been approved by alexcrichton

bors added a commit that referenced this pull request May 27, 2015

@bors

This comment has been minimized.

Copy link
Contributor

bors commented May 27, 2015

⌛️ Testing commit 377b090 with merge eb16ad6...

@bors bors merged commit 377b090 into rust-lang:master May 27, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@eddyb eddyb deleted the eddyb:oh-snap-ctfe-arrived branch May 27, 2015

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented May 27, 2015

I was a little surprised to see that usage of a const fn is stable today even if defining it is not. This means that calling UnsafeCell::new to create a static UnsafeCell is now stable (which I think was unintentional). I believe that @nikomatsakis is working on a patch to feature-gate usage, however.

@pythonesque

This comment has been minimized.

Copy link
Contributor

pythonesque commented May 27, 2015

Oh my god this is amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.