Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement defaults for associated types #25796

Merged
merged 4 commits into from May 28, 2015

Conversation

Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@arielb1 @eddyb @bors @nikomatsakis @tamird
@arielb1
Copy link
Contributor

arielb1 commented May 26, 2015

r? @eddyb

Fixes #19476.

@rust-highfive rust-highfive assigned eddyb May 26, 2015

@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented May 26, 2015

LGTM. Doesn't this close one or more issues?
@arielb1

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

arielb1 commented May 26, 2015

Not any that I know.
Ariel Ben-Yehuda
Add tests for fixed issues 
Fixes #23037.
Fixes #25339.
Loading status checks…
65a3245
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member

eddyb commented May 26, 2015

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 26, 2015

📌 Commit 65a3245 has been approved by eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 27, 2015

⌛️ Testing commit 65a3245 with merge c8d3aa8...

bors added a commit that referenced this pull request May 27, 2015

@bors
Auto merge of #25796 - arielb1:default-assoc, r=eddyb 
r? @eddyb

Fixes #19476.
c8d3aa8
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 27, 2015

💔 Test failed - auto-mac-64-opt
@tamird

This comment has been minimized.

Sign in to view
Copy link

tamird commented on src/test/compile-fail/issue-23073.rs in 65a3245 May 27, 2015

fails tidy
Ariel Ben-Yehuda
test fixes
Loading status checks…
c68e652
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link

nikomatsakis commented on src/librustc/middle/traits/project.rs in ae10e47 May 27, 2015

can you add a comment here? in particular, it'd be nice to say "// search trait for default" and "// search impl for explicit" or something like that

This comment has been minimized.

Sign in to view
Copy link

nikomatsakis replied May 27, 2015

(that said, I'd prefer if the defaults were applied earlier, so that project didn't have to worry about it -- but I think that could be part of a more general refactoring cleaning up the haphazard mess of data structures that are in use here)
Ariel Ben-Yehuda
Address review comments
Loading status checks…
699fc80
@nikomatsakis

This comment has been minimized.

Sign in to view
Copy link
Contributor

nikomatsakis commented May 27, 2015

@bors r=eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 27, 2015

📌 Commit 699fc80 has been approved by eddyb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 27, 2015

⌛️ Testing commit 699fc80 with merge 2058f87...

bors added a commit that referenced this pull request May 27, 2015

@bors
Auto merge of #25796 - arielb1:default-assoc, r=eddyb 
r? @eddyb

Fixes #19476.
2058f87
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 27, 2015

⛄️ The build was interrupted to prioritize another pull request.

bors added a commit that referenced this pull request May 27, 2015

@bors
Auto merge of #25796 - arielb1:default-assoc, r=eddyb 
r? @eddyb

Fixes #19476.
Loading status checks…
f3819f0
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented May 27, 2015

⌛️ Testing commit 699fc80 with merge f3819f0...
@bors

@bors bors merged commit 699fc80 into rust-lang:master May 28, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.