Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nested generics for the last field of structs in unsizing. #26038

Merged
merged 1 commit into from Jun 6, 2015

Conversation

Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@eddyb @luqmana @bors @brson @nrc
@eddyb
Copy link
Member

eddyb commented Jun 5, 2015

Allows Rc<RefCell<Trait>> and other containers. Fixes #25351.
r? @nrc This is the discussed strategy, more or less.

@rust-highfive rust-highfive assigned nrc Jun 5, 2015

@luqmana

This comment has been minimized.

Sign in to view
Copy link
Member

luqmana commented Jun 6, 2015

\o/ @bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 6, 2015

📌 Commit 01dee1b has been approved by luqmana
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 6, 2015

⌛️ Testing commit 01dee1b with merge 14d0828...

bors added a commit that referenced this pull request Jun 6, 2015

@bors
Auto merge of #26038 - eddyb:dst-nested, r=luqmana 
Allows `Rc<RefCell<Trait>>` and other containers. Fixes #25351.
r? @nrc This is the discussed strategy, more or less.
14d0828
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 6, 2015

💔 Test failed - auto-win-gnu-64-nopt-t
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member Author

eddyb commented Jun 6, 2015

@bors retry

bors added a commit that referenced this pull request Jun 6, 2015

@bors
Auto merge of #26038 - eddyb:dst-nested, r=luqmana 
Allows `Rc<RefCell<Trait>>` and other containers. Fixes #25351.
r? @nrc This is the discussed strategy, more or less.
ea5523a
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 6, 2015

⌛️ Testing commit 01dee1b with merge ea5523a...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 6, 2015

💔 Test failed - auto-linux-32-opt
@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member Author

eddyb commented Jun 6, 2015

Uhm, cosmic rays? cc @alexcrichton @brson
@bors retry

bors added a commit that referenced this pull request Jun 6, 2015

@bors
Auto merge of #26038 - eddyb:dst-nested, r=luqmana 
Allows `Rc<RefCell<Trait>>` and other containers. Fixes #25351.
r? @nrc This is the discussed strategy, more or less.
Loading status checks…
bfd072d
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 6, 2015

⌛️ Testing commit 01dee1b with merge bfd072d...
@bors

@bors bors merged commit 01dee1b into rust-lang:master Jun 6, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@eddyb eddyb deleted the eddyb:dst-nested branch Jun 6, 2015

@eddyb eddyb referenced this pull request Jun 17, 2015

Closed

ICE: translating unsupported cast: `alloc::rc::Rc<[i32]>` in beta #26352

@eddyb

This comment has been minimized.

Sign in to view
Copy link
Member Author

eddyb commented Jun 17, 2015

triage: beta-nominated

Found a case where stable (1.0) compiles http://is.gd/BAToXc beta (1.1) doesn't http://is.gd/pnxDTf and nightly (1.2) compiles again http://is.gd/g3dEUF - so this PR actually fixes a regression (@nrc warned me but I had forgotten).

@eddyb eddyb added the beta-nominated label Jun 17, 2015

@brson brson removed the beta-nominated label Jun 18, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jun 18, 2015

Not backporting per @nrc and @nmatsakis. DST coercions just aren't quite ready for 1.1 and the risk of futzing with them is high.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.