Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose llvm's stack intrinsics #26059

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@oli-obk
Copy link
Contributor

oli-obk commented Jun 6, 2015

while I was doing this I found loads of dead code like the ArrayAlloca function. Does it make sense to remove such functions or should we just wait until someone implements code coverage testing for rustc and does this properly?

Oliver 'ker' Schneider
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Jun 6, 2015

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Jun 7, 2015

Removing dead code is fine IMO. On the other hand, I’ve already tried adding intrinsics and not immediately using them in rustc or exposing them in std several times in the past failing each time, I suspect you might fail as well.

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

oli-obk commented Jun 7, 2015

well... My use case is a Vla and a StackBox, so we can get DSTs on the stack, but I need compiler support for it, can't do it outside since afaik there isn't such a thing as a trans-plugin. I'll create a crate, and once it's working I'll add an rfc for std

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Jun 7, 2015

I think that it may be more appropriate for these to go through an RFC first. The extra morestack symbols needed by the alloca function, for example, worries me that there's some more discussion which may need to happen there.

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

oli-obk commented Jun 7, 2015

oh, sorry, didn't know adding intrinsics needed an RFC. RFC coming up

@oli-obk oli-obk closed this Jun 7, 2015

@oli-obk oli-obk deleted the oli-obk:alloca branch Jul 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.