Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upexpose llvm's stack intrinsics #26059
Conversation
rust-highfive
assigned
huonw
Jun 6, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
Removing dead code is fine IMO. On the other hand, I’ve already tried adding intrinsics and not immediately using them in rustc or exposing them in std several times in the past failing each time, I suspect you might fail as well. |
This comment has been minimized.
This comment has been minimized.
|
well... My use case is a |
This comment has been minimized.
This comment has been minimized.
|
I think that it may be more appropriate for these to go through an RFC first. The extra morestack symbols needed by the alloca function, for example, worries me that there's some more discussion which may need to happen there. |
This comment has been minimized.
This comment has been minimized.
|
oh, sorry, didn't know adding intrinsics needed an RFC. RFC coming up |
oli-obk commentedJun 6, 2015
while I was doing this I found loads of dead code like the
ArrayAllocafunction. Does it make sense to remove such functions or should we just wait until someone implements code coverage testing for rustc and does this properly?