Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure projections are not counted as constraining type parameters. #26275

Merged
merged 1 commit into from Jun 15, 2015

Conversation

Projects
None yet
4 participants
@arielb1
Copy link
Contributor

arielb1 commented Jun 13, 2015

Fixes #26262

Because this rejects code that previously compiled, this is a [breaking-change]

r? @nikomatsakis

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

nikomatsakis commented Jun 15, 2015

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 15, 2015

📌 Commit 3ca4d92 has been approved by nikomatsakis

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 15, 2015

⌛️ Testing commit 3ca4d92 with merge 73fb19c...

bors added a commit that referenced this pull request Jun 15, 2015

Auto merge of #26275 - arielb1:unconstrained-projection, r=nikomatsakis
Fixes #26262

Because this rejects code that previously compiled, this is a [breaking-change]

r? @nikomatsakis

@bors bors merged commit 3ca4d92 into rust-lang:master Jun 15, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bluss

This comment has been minimized.

Copy link
Contributor

bluss commented Jun 16, 2015

FYI, this breaks the petgraph crate. The impl block in question is using impl<G: Visitable> Dfs<G::NodeId, G::Map> code here and build log here

src/visit.rs:236:6: 236:7 error: the type parameter `G` is not constrained by the impl trait, self type, or predicates [E0207]
src/visit.rs:236 impl<G: Visitable> Dfs<G::NodeId, G::Map>

Edit, note I'm fixing it as we speak, so for my own sake this is no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.