Skip to content

Don't create random directories #26277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2015

Conversation

aidanhs
Copy link
Member

@aidanhs aidanhs commented Jun 13, 2015

The last commit is optional. If you opt not to take it I can improve on the 'this is magic' comment.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aidanhs aidanhs force-pushed the aphs-dont-make-random-directories branch from be5ef35 to dea6b2d Compare June 13, 2015 16:26
@aidanhs aidanhs force-pushed the aphs-dont-make-random-directories branch from dea6b2d to 09ed759 Compare June 13, 2015 16:26
@aidanhs aidanhs force-pushed the aphs-dont-make-random-directories branch from 09ed759 to fca6670 Compare June 13, 2015 16:27
@alexcrichton
Copy link
Member

cc @brson, this macro is just madness!

@bors: r+ fca6670

Thanks though!

@bors
Copy link
Collaborator

bors commented Jun 13, 2015

⌛ Testing commit fca6670 with merge c43cdb8...

bors added a commit that referenced this pull request Jun 13, 2015
…lexcrichton

The last commit is optional. If you opt not to take it I can improve on the 'this is magic' comment.
@bors bors merged commit fca6670 into rust-lang:master Jun 13, 2015
@aidanhs aidanhs deleted the aphs-dont-make-random-directories branch August 26, 2015 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants