New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create random directories #26277

Merged
merged 3 commits into from Jun 13, 2015

Conversation

Projects
None yet
4 participants
@aidanhs
Member

aidanhs commented Jun 13, 2015

The last commit is optional. If you opt not to take it I can improve on the 'this is magic' comment.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Jun 13, 2015

Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Collaborator

rust-highfive commented Jun 13, 2015

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Jun 13, 2015

Member

cc @brson, this macro is just madness!

@bors: r+ fca6670

Thanks though!

Member

alexcrichton commented Jun 13, 2015

cc @brson, this macro is just madness!

@bors: r+ fca6670

Thanks though!

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jun 13, 2015

Contributor

⌛️ Testing commit fca6670 with merge c43cdb8...

Contributor

bors commented Jun 13, 2015

⌛️ Testing commit fca6670 with merge c43cdb8...

bors added a commit that referenced this pull request Jun 13, 2015

Auto merge of #26277 - aidanhs:aphs-dont-make-random-directories, r=a…
…lexcrichton

The last commit is optional. If you opt not to take it I can improve on the 'this is magic' comment.

@bors bors merged commit fca6670 into rust-lang:master Jun 13, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@aidanhs aidanhs deleted the aidanhs:aphs-dont-make-random-directories branch Aug 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment