Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUse a stage-dependent shared library directory for testing. #26405
Conversation
rust-highfive
assigned
alexcrichton
Jun 18, 2015
This comment has been minimized.
This comment has been minimized.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
Have you checked to make sure this actually works? Testing locally we still pass |
This comment has been minimized.
This comment has been minimized.
|
This also appears to have been added in c60d9ad, and although I don't remember the precise reason why this commit does indeed break cross-host builds. I configured a host of 32/64 bit locally and got this during compilation:
|
This comment has been minimized.
This comment has been minimized.
|
Oh, right, The cross-host build issue is one I had not anticipated, and I will have to look into it, but I still don't believe hardcoding |
This comment has been minimized.
This comment has been minimized.
|
I'll close this since |
eddyb
closed this
Jun 25, 2015
This comment has been minimized.
This comment has been minimized.
|
This makefile tweak allows collectionstest to run in stage0, do you think it can be fixed & merged? |
This comment has been minimized.
This comment has been minimized.
|
@bluss I think I was mistaken, it broke again. Maybe the removal of stage1 libs during reconfigure made it work for a little bit. |
eddyb commentedJun 18, 2015
Unbreaks
check-stage0-CRATEwhereCRATEmay be one ofcoretest,std,syntax,rustc_driver, etc.