Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some 1.2 relnotes #26613

Merged
merged 2 commits into from Jul 10, 2015

Conversation

Reviewers
No reviews
Assignees

@aturon aturon

Labels
beta-accepted
Projects
None yet
Milestone
No milestone
8 participants
@brson @rust-highfive @alexcrichton @bluss @bors @arielb1 @nikomatsakis @aturon
@brson
Copy link
Contributor

brson commented Jun 27, 2015

Haven't finished these, but since others are also working on this and I'm on vacation I figured I should get this in.

@rust-highfive rust-highfive assigned nikomatsakis Jun 27, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jun 27, 2015

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jun 27, 2015

r? @aturon

@rust-highfive rust-highfive assigned aturon and unassigned nikomatsakis Jun 27, 2015

AUTHORS.txt
@@ -760,10 +813,13 @@ nsf <no.smile.face@gmail.com>
nwin <nwin@users.noreply.github.com>
Oak <White-Oak@users.noreply.github.com>
OGINO Masanori <masanori.ogino@gmail.com>
OlegTsyba <idethrone1@gmail.com>
Oliver Schneider <git1984941651981@oli-obk.de>

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Jun 27, 2015

Member

Candidate for a mailmap entry?
AUTHORS.txt Outdated
@@ -786,7 +843,9 @@ Paul Banks <banks@banksdesigns.co.uk>
Paul Collier <paul@paulcollier.ca>
Paul Collins <paul@ondioline.org>
Paul Crowley <paulcrowley@google.com>
Paul Faria <Nashenas88@gmail.com>

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Jun 27, 2015

Member

Another candidate for a mailmap entry perhaps?
AUTHORS.txt Outdated
Pete Hunt <petehunt@users.noreply.github.com>
Peter Atashian <retep998@gmail.com>
Peter Elmers <peter.elmers@rice.edu>
Peter Elmers <peter.elmers@yahoo.com>

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Jun 27, 2015

Member

(mailmap)
AUTHORS.txt
@@ -1058,12 +1134,15 @@ Will <will@glozer.net>
Wojciech Ogrodowczyk <github@haikuco.de>
wonyong kim <wonyong.kim@samsung.com>
xales <xales@naveria.com>
Xuefeng Wu <benewu@gmail.com>
XuefengWu <benewu@gmail.com>

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Jun 27, 2015

Member

(mailmap above and below I think)
RELEASES.md Outdated
poisoned lock without attempting to take the lock.
* On Unix the [`FromRawFd`] trait is implemented for [`Stdio`], and
[`AsRawFd`] for [`ChildStdin`], [`ChildStdout`], [`ChildStderr`].
On Windows the FromRawHandle` trait is implemented for `Stdio`,

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Jun 27, 2015

Member

I think the backticks here are off-by-one
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jun 27, 2015

Nice! r=me with a few nits
RELEASES.md
for writing data to formatted strings, similar to [`io::Write`].
* [`fmt::Formatter`] adds 'debug builder' methods, [`debug_struct`],
[`debug_tuple`], [`debug_list`], [`debug_set`], [`debug_map`]. These
are used by code generators to emit implementations of [`Debug`].

This comment has been minimized.

Sign in to view
Copy link
@bluss

bluss Jun 27, 2015

Contributor

Maybe this is the right place to mention {:#?} (pretty printing by using alternative format for Debug). It's hugely useful so we need to document it. It's a debug printer feature, only problem it was available already from Rust 1.1 in derived Debug impls.
@bluss

This comment has been minimized.

Sign in to view
Copy link
Contributor

bluss commented Jun 27, 2015

I tagged PR #26058, so its entry could read

[Language]
* Patterns with `ref mut` now correctly invoke [`DerefMut`] when matching against dereferencable values.

[`DerefMut`]: http://doc.rust-lang.org/nightly/std/ops/trait.DerefMut.html
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jun 27, 2015

☔️ The latest upstream changes (presumably #26579) made this pull request unmergeable. Please resolve the merge conflicts.
.mailmap
@@ -13,7 +13,7 @@ Alex Rønne Petersen <alex@lycus.org>
Andreas Gal <gal@mozilla.com> <andreas.gal@gmail.com>
Andrew Poelstra <asp11@sfu.ca> <apoelstra@wpsoftware.net>
Anton Löfgren <anton.lofgren@gmail.com> <alofgren@op5.com>
Ariel Ben-Yehuda <arielb1@mail.tau.ac.il> <ariel.byd@gmail.com>
Ariel Ben-Yehuda <arielb1@mail.tau.ac.il> arielb1 <arielb1@mail.tau.ac.il> <ariel.byd@gmail.com>

This comment has been minimized.

Sign in to view
Copy link
@arielb1

arielb1 Jun 27, 2015

Contributor

There's no need to have my mail twice.

@brson brson added the beta-nominated label Jul 1, 2015

@alexcrichton alexcrichton added the beta-accepted label Jul 7, 2015

@brson brson force-pushed the brson:relnotes branch from 4664dd2 to e731e70 Jul 9, 2015

@brson brson force-pushed the brson:relnotes branch 5 times, most recently from 6337577 to 9cbef6c Jul 9, 2015

@brson
Update RELEASES.md for 1.2
Loading status checks…
0d60e8d

@brson brson force-pushed the brson:relnotes branch from 9cbef6c to 0d60e8d Jul 9, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 9, 2015

@bors r=alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 9, 2015

📌 Commit 0d60e8d has been approved by alexcrichton

bors added a commit that referenced this pull request Jul 10, 2015

@bors
Auto merge of #26613 - brson:relnotes, r=alexcrichton 
Haven't finished these, but since [others](#26579) are also working on this and I'm on vacation I figured I should get this in.
fc03764
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 10, 2015

⌛️ Testing commit 0d60e8d with merge fc03764...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 10, 2015

💔 Test failed - auto-linux-32-opt
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jul 10, 2015

@bors: retry

On Thu, Jul 9, 2015 at 5:44 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-32-opt
http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5664

—
Reply to this email directly or view it on GitHub
#26613 (comment).

bors added a commit that referenced this pull request Jul 10, 2015

@bors
Auto merge of #26613 - brson:relnotes, r=alexcrichton 
Haven't finished these, but since [others](#26579) are also working on this and I'm on vacation I figured I should get this in.
a5e0348
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 10, 2015

⌛️ Testing commit 0d60e8d with merge a5e0348...
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jul 10, 2015

@bors: retry force clean
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 10, 2015

⌛️ Testing commit 0d60e8d with merge 9cb1c29...

bors added a commit that referenced this pull request Jul 10, 2015

@bors
Auto merge of #26613 - brson:relnotes, r=alexcrichton 
Haven't finished these, but since [others](#26579) are also working on this and I'm on vacation I figured I should get this in.
9cb1c29
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 10, 2015

💔 Test failed - auto-mac-32-opt
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jul 10, 2015

@bors: retry

On Thu, Jul 9, 2015 at 11:50 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-32-opt
http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/5689

—
Reply to this email directly or view it on GitHub
#26613 (comment).
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 10, 2015

⌛️ Testing commit 0d60e8d with merge 4695fbd...

bors added a commit that referenced this pull request Jul 10, 2015

@bors
Auto merge of #26613 - brson:relnotes, r=alexcrichton 
Haven't finished these, but since [others](#26579) are also working on this and I'm on vacation I figured I should get this in.
Loading status checks…
4695fbd
@bors

@bors bors merged commit 0d60e8d into rust-lang:master Jul 10, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@brson brson referenced this pull request Jul 27, 2015

Merged

Beta next #27334

@brson brson removed the beta-nominated label Jul 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.