Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upReport memory use in time-passes #26691
Conversation
rust-highfive
assigned
huonw
Jun 30, 2015
alexcrichton
reviewed
Jun 30, 2015
src/librustc/util/common.rs
Outdated
| Some(npages * ::std::env::page_size()) | ||
| } | ||
|
|
||
| #[cfg(not(target_os="linux"))] |
This comment has been minimized.
This comment has been minimized.
alexcrichton
Jun 30, 2015
Member
If this is just using normal apis, could this do if cfg! instead of #[cfg]? (helps porting and dealing with unused imports).
nrc
force-pushed the
nrc:mem
branch
from
650c028
to
7713e14
Jul 1, 2015
This comment has been minimized.
This comment has been minimized.
|
Updated; r? @alexcrichton |
rust-highfive
assigned
alexcrichton
and unassigned
huonw
Jul 1, 2015
This comment has been minimized.
This comment has been minimized.
|
Why not Windows as well? let mut pmc: PROCESS_MEMORY_COUNTERS = mem::zeroed();
pmc.cb = mem::size_of_val(pmc);
assert!(GetProcessMemoryInfo(GetCurrentProcess(), &mut pmc, pmc.cb) != 0);
return pmc.WorkingSetSize; |
This comment has been minimized.
This comment has been minimized.
|
@retep998 a PR would be very welcome! (I can't test it myself, so not keen to try). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jul 2, 2015
This comment has been minimized.
This comment has been minimized.
bors
merged commit 7713e14
into
rust-lang:master
Jul 2, 2015
retep998
referenced this pull request
Jul 8, 2015
Merged
Report memory use in time-passes on Windows #26883
bors
added a commit
that referenced
this pull request
Jul 8, 2015
bors
added a commit
that referenced
this pull request
Jul 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nrc commentedJun 30, 2015
Reports the resident set size after each pass (linux-only).
r? @huonw or @alexcrichton