Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Fix formatting flags for chars #26698

Merged
merged 1 commit into from Jul 1, 2015

Conversation

Reviewers
No reviews
Assignees

@huonw huonw

Labels
T-libs beta-accepted
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @rust-highfive @huonw @bors @brson
@alexcrichton
Copy link
Member

alexcrichton commented Jul 1, 2015

This recently regressed in #24689, and this updates the Display implementation
to take formatting flags into account.

Closes #26625
@alexcrichton
std: Fix formatting flags for chars 
This recently regressed in #24689, and this updates the `Display` implementation
to take formatting flags into account.

Closes #26625
Loading status checks…
98566ea

@rust-highfive rust-highfive assigned huonw Jul 1, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jul 1, 2015

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 1, 2015

Fix is by @SimonSapin
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 1, 2015

Nominating for backporting to beta as well (as this regression first appeared in beta)

@alexcrichton alexcrichton added the beta-nominated label Jul 1, 2015

@huonw

This comment has been minimized.

Sign in to view
Copy link
Member

huonw commented Jul 1, 2015

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 1, 2015

📌 Commit 98566ea has been approved by huonw

bors added a commit that referenced this pull request Jul 1, 2015

@bors
Auto merge of #26698 - alexcrichton:char-fmt, r=huonw 
This recently regressed in #24689, and this updates the `Display` implementation
to take formatting flags into account.

Closes #26625
Loading status checks…
1fc0f68
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 1, 2015

⌛️ Testing commit 98566ea with merge 1fc0f68...
@bors

@bors bors merged commit 98566ea into rust-lang:master Jul 1, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton added the T-libs label Jul 7, 2015

@alexcrichton alexcrichton deleted the alexcrichton:char-fmt branch Jul 8, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 8, 2015

accepting for beta

@alexcrichton alexcrichton added the beta-accepted label Jul 8, 2015

@alexcrichton alexcrichton referenced this pull request Jul 8, 2015

Merged

Backporting accepted PRs to beta #26901

@brson brson removed the beta-nominated label Jul 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.