Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-gate #[prelude_import]. #26699

Merged
merged 1 commit into from Jul 7, 2015

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
T-lang regression-from-stable-to-nightly
Projects
None yet
Milestone
No milestone
7 participants
@eddyb @rust-highfive @alexcrichton @huonw @steveklabnik @brson @bors
@eddyb
Copy link
Member

eddyb commented Jul 1, 2015

Closes #26690.

@rust-highfive rust-highfive assigned alexcrichton Jul 1, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jul 1, 2015

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb eddyb force-pushed the eddyb:unstable-prelude_import branch 2 times, most recently from eea540f to 0caedc3 Jul 1, 2015

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jul 1, 2015

cc @huonw, you seem pretty familiar with the allow_internal_unstable stuff.

This may also be good to run through Crater first just to double check, but I'd also be fine just going ahead and merging this and covering it in one of the regular "regressions against beta" reports.

Also, nominating for a beta backport.

@alexcrichton alexcrichton added beta-nominated T-lang labels Jul 1, 2015

src/libsyntax/std_inject.rs
}
};
let expn_id = sess.codemap().record_expansion(info);
let mut sp = sp;

This comment has been minimized.

Sign in to view
Copy link
@huonw

huonw Jul 1, 2015

Member

Could be Span { expn_id: expn_id, .. sp }?
@huonw

This comment has been minimized.

Sign in to view
Copy link
Member

huonw commented Jul 1, 2015

r=me with an passing crater run.
@eddyb
Feature-gate #[prelude_import].
Loading status checks…
6a3b385

@eddyb eddyb force-pushed the eddyb:unstable-prelude_import branch from 0caedc3 to 6a3b385 Jul 5, 2015

@steveklabnik

This comment has been minimized.

Sign in to view
Copy link
Member

steveklabnik commented Jul 6, 2015

/cc @brson, can we get a crater run on this?
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jul 6, 2015

I will start now.
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jul 6, 2015

Crater says all good.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Jul 6, 2015

@bors: r=huonw 6a3b385
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 7, 2015

⌛️ Testing commit 6a3b385 with merge ed14593...

bors added a commit that referenced this pull request Jul 7, 2015

@bors
Auto merge of #26699 - eddyb:unstable-prelude_import, r=huonw 
Closes #26690.
Loading status checks…
ed14593
@bors

@bors bors merged commit 6a3b385 into rust-lang:master Jul 7, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@eddyb eddyb deleted the eddyb:unstable-prelude_import branch Jul 7, 2015

@brson brson added the regression-from-stable-to-nightly label Jul 10, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jul 29, 2015

Not accepted for backport. People aren't using this and we can break it at will. Bugfix.

@brson brson added beta-accepted and removed beta-accepted beta-nominated labels Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.