Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make associated type defaults closer to the spec #26728

Merged
merged 2 commits into from Jul 4, 2015

Conversation

Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@arielb1 @nrc @bors @mitaa @brson
@arielb1
Copy link
Contributor

arielb1 commented Jul 1, 2015

r? @nrc

@rust-highfive rust-highfive assigned nrc Jul 1, 2015

@arielb1 arielb1 force-pushed the arielb1:assoc-maybe branch from ec99626 to e2796d7 Jul 1, 2015

src/librustc_typeck/check/mod.rs Outdated
if let Some(at) = overriden_associated_type {
span_note!(tcx.sess, at.span,
"an overriden associated type \
requires reimplementations of all trait-items");

This comment has been minimized.

Sign in to view
Copy link
@nrc

nrc Jul 3, 2015

Member

This error message could be much more helpful - showing what caused the problem and what needs to be fixed. Happy to see that as follow-up rather than doing it now, but please file an issue and add a FIXME here.
@nrc

This comment has been minimized.

Sign in to view
Copy link
Member

nrc commented Jul 3, 2015

Code looks good. I thought we were going to make this a warning at first? Is this not the breaking change we discussed on irc?

@arielb1 arielb1 force-pushed the arielb1:assoc-maybe branch 4 times, most recently from 0d1c66e to 4f165c3 Jul 3, 2015

@arielb1

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

arielb1 commented Jul 3, 2015

Updated.
@nrc

This comment has been minimized.

Sign in to view
Copy link
Member

nrc commented Jul 4, 2015

@bors: r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 4, 2015

📌 Commit 4f165c3 has been approved by nrc
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 4, 2015

⌛️ Testing commit 4f165c3 with merge 5e54df3...

bors added a commit that referenced this pull request Jul 4, 2015

@bors
Auto merge of #26728 - arielb1:assoc-maybe, r=nrc 
r? @nrc
5e54df3
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 4, 2015

💔 Test failed - auto-win-gnu-64-opt

Ariel Ben-Yehuda added some commits Jun 30, 2015

Ariel Ben-Yehuda
Clean-up check_impl_items_against_trait
ace8670
Ariel Ben-Yehuda
require reimplementations of all items when a defaulted associated ty… 
…pe is overriden

This is a
[breaking-change]
but it follows the RFC (not sure whether it will be accepted).
Loading status checks…
6b27005

@arielb1 arielb1 force-pushed the arielb1:assoc-maybe branch from 4f165c3 to 6b27005 Jul 4, 2015

@arielb1

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

arielb1 commented Jul 4, 2015

@bors r=nrc

Reassigned error #
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 4, 2015

📌 Commit 6b27005 has been approved by nrc

bors added a commit that referenced this pull request Jul 4, 2015

@bors
Auto merge of #26728 - arielb1:assoc-maybe, r=nrc 
r? @nrc
Loading status checks…
638ffec
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 4, 2015

⌛️ Testing commit 6b27005 with merge 638ffec...
@bors

@bors bors merged commit 6b27005 into rust-lang:master Jul 4, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

dgrunwald added a commit to dgrunwald/rust-cpython that referenced this pull request Jul 8, 2015

@dgrunwald
Adjust to breaking change rust-lang/rust#26728
Loading status checks…
04ea39d

SimonSapin added a commit to servo/rust-cssparser that referenced this pull request Jul 10, 2015

@SimonSapin
Remove some default associated types, so that default methods don’t h… 
…ave to be overridden.

Since rust-lang/rust#26728 , Servo would get build errors like:

    error: the following trait items need to be reimplemented as `AtRule` was overridden: `rule_without_block` [E0399]
        type AtRule = CSSRule;
        ^~~~~~~~~~~~~~~~~~~~~~
Loading status checks…
26a3c05

@brson brson added the beta-nominated label Jul 27, 2015

@brson brson referenced this pull request Jul 28, 2015

Closed

Associated defaults - for 1.2.0 #27364

@mitaa

This comment has been minimized.

Sign in to view
Copy link
Contributor

mitaa commented Jul 29, 2015

Which RFC? Link?
@mitaa

This comment has been minimized.

Sign in to view
Copy link
Contributor

mitaa commented Jul 29, 2015

I see.. the original rust-lang/rfcs#195.
Sorry for the noise.

@brson brson added the relnotes label Jul 29, 2015

@brson brson removed beta-nominated relnotes labels Jul 29, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jul 29, 2015

Not accepted for backporting to 1.2. After discussing with @nikomatsakis we're going to instead backport a patch to feature-gate default type parameters because there are still open questions about how they should work.

@aturon aturon referenced this pull request Jul 29, 2015

Closed

Error E0399 regression on nightly from beta. #27377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.