/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly improve formatter trait docs #26828

Merged
merged 1 commit into from Jul 7, 2015

Conversation

Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@steveklabnik @rust-highfive @bluss @bors @nikomatsakis
@steveklabnik
Member

steveklabnik commented Jul 6, 2015

Each formatting trait now has an example of implementation, as well as a
fuller description of what it's supposed to output.

It also contains a link to the module-level documentation which

Fixes #25765

@rust-highfive rust-highfive assigned nikomatsakis Jul 6, 2015

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Jul 6, 2015

Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)
Collaborator

rust-highfive commented Jul 6, 2015

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)
Show outdated Hide outdated src/libcore/fmt/mod.rs
Show outdated Hide outdated src/libcore/fmt/mod.rs
@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Jul 6, 2015

Member

Thanks @bluss, even better now :)
Member

steveklabnik commented Jul 6, 2015

Thanks @bluss, even better now :)
Show outdated Hide outdated src/libcore/fmt/mod.rs
@bluss

This comment has been minimized.

Show comment
Hide comment
@bluss

bluss Jul 6, 2015

Contributor

r=me with the scientific notation confirmed and tidy errors fixed!

Nice new avatar!
Contributor

bluss commented Jul 6, 2015

r=me with the scientific notation confirmed and tidy errors fixed!

Nice new avatar!
@steveklabnik
Significantly improve formatter trait docs 
Each formatting trait now has an example of implementation, as well as a
fuller description of what it's supposed to output.

It also contains a link to the module-level documentation which

Fixes #25765
3a6cd64
@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Jul 6, 2015

Member

@bors: r=bluss rollup
Member

steveklabnik commented Jul 6, 2015

@bors: r=bluss rollup
@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Jul 6, 2015

Contributor

📌 Commit 3a6cd64 has been approved by bluss
Contributor

bors commented Jul 6, 2015

📌 Commit 3a6cd64 has been approved by bluss
@steveklabnik

This comment has been minimized.

Show comment
Hide comment
@steveklabnik

steveklabnik Jul 6, 2015

Member

Nice new avatar

Thanks :) been using it on Twitter for a while, realized I forgot to update it here...
Member

steveklabnik commented Jul 6, 2015

Nice new avatar

Thanks :) been using it on Twitter for a while, realized I forgot to update it here...

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 6, 2015

@steveklabnik
Rollup merge of #26828 - steveklabnik:gh25765, r=bluss 
Each formatting trait now has an example of implementation, as well as a
fuller description of what it's supposed to output.

It also contains a link to the module-level documentation which

Fixes #25765
b170970

@steveklabnik steveklabnik referenced this pull request Jul 6, 2015

Closed

Rollup of 8 pull requests #26836

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 6, 2015

@steveklabnik
Rollup merge of #26828 - steveklabnik:gh25765, r=bluss 
Each formatting trait now has an example of implementation, as well as a
fuller description of what it's supposed to output.

It also contains a link to the module-level documentation which

Fixes #25765
57e0e19

@steveklabnik steveklabnik referenced this pull request Jul 6, 2015

Closed

Rollup of 8 pull requests #26837

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 7, 2015

@steveklabnik
Rollup merge of #26828 - steveklabnik:gh25765, r=bluss 
Each formatting trait now has an example of implementation, as well as a
fuller description of what it's supposed to output.

It also contains a link to the module-level documentation which

Fixes #25765
3e62e20

@steveklabnik steveklabnik referenced this pull request Jul 7, 2015

Merged

Rollup of 10 pull requests #26844

bors added a commit that referenced this pull request Jul 7, 2015

@bors
Auto merge of #26844 - steveklabnik:rollup, r=steveklabnik 
- Successful merges: #26599, #26761, #26807, #26809, #26825, #26827, #26828, #26832, #26834, #26835
- Failed merges: #26796
26f0cd5

@bors bors merged commit 3a6cd64 into rust-lang:master Jul 7, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment