Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "msvc: Enable landing pads by default" #26919

Merged
merged 1 commit into from Jul 10, 2015

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @rust-highfive @brson @bors @pcwalton
@alexcrichton
Copy link
Member

alexcrichton commented Jul 9, 2015

There are a number of problems with MSVC landing pads today:

  • They only work about 80% of the time with optimizations enabled. For example when running the run-pass test suite a failing test will cause compiletest to segfault (b/c of a thread panic). There are also a large number of run-fail tests which will simply crash.
  • Enabling landing pads caused the regression seen in #26915.

Overall it looks like LLVM's support for MSVC landing pads isn't as robust as we'd like for now, so let's take a little more time before we turn them on by default.

Closes #26915
@alexcrichton
Revert "msvc: Enable landing pads by default" 
This reverts commit f9de964.

Conflicts:
	src/librustc_trans/trans/base.rs
Loading status checks…
813cfa5

@rust-highfive rust-highfive assigned pcwalton Jul 9, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Jul 9, 2015

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 9, 2015

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned pcwalton Jul 9, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Jul 9, 2015

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 9, 2015

📌 Commit 813cfa5 has been approved by brson

bors added a commit that referenced this pull request Jul 9, 2015

@bors
Auto merge of #26919 - alexcrichton:msvc-turn-off-unwinding, r=brson 
There are a number of problems with MSVC landing pads today:

* They only work about 80% of the time with optimizations enabled. For example when running the run-pass test suite a failing test will cause `compiletest` to segfault (b/c of a thread panic). There are also a large number of run-fail tests which will simply crash.
* Enabling landing pads caused the regression seen in #26915.

Overall it looks like LLVM's support for MSVC landing pads isn't as robust as we'd like for now, so let's take a little more time before we turn them on by default.


Closes #26915
56e1c47
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 9, 2015

⌛️ Testing commit 813cfa5 with merge 56e1c47...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 9, 2015

💔 Test failed - auto-linux-32-opt
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 9, 2015

@bors: retry

On Thu, Jul 9, 2015 at 1:46 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-32-opt
http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5657

—
Reply to this email directly or view it on GitHub
#26919 (comment).

bors added a commit that referenced this pull request Jul 9, 2015

@bors
Auto merge of #26919 - alexcrichton:msvc-turn-off-unwinding, r=brson 
There are a number of problems with MSVC landing pads today:

* They only work about 80% of the time with optimizations enabled. For example when running the run-pass test suite a failing test will cause `compiletest` to segfault (b/c of a thread panic). There are also a large number of run-fail tests which will simply crash.
* Enabling landing pads caused the regression seen in #26915.

Overall it looks like LLVM's support for MSVC landing pads isn't as robust as we'd like for now, so let's take a little more time before we turn them on by default.


Closes #26915
3c935f8
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 9, 2015

⌛️ Testing commit 813cfa5 with merge 3c935f8...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 9, 2015

💔 Test failed - auto-linux-32-opt
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 9, 2015

@bors: retry

On Thu, Jul 9, 2015 at 2:37 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-32-opt
http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5659

—
Reply to this email directly or view it on GitHub
#26919 (comment).
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 9, 2015

⌛️ Testing commit 813cfa5 with merge 3030138...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 9, 2015

💔 Test failed - auto-win-gnu-64-nopt-t
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Jul 9, 2015

@bors: retry

On Thu, Jul 9, 2015 at 2:50 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-gnu-64-nopt-t/builds/620

—
Reply to this email directly or view it on GitHub
#26919 (comment).
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 10, 2015

⌛️ Testing commit 813cfa5 with merge cdcce3b...

bors added a commit that referenced this pull request Jul 10, 2015

@bors
Auto merge of #26919 - alexcrichton:msvc-turn-off-unwinding, r=brson 
There are a number of problems with MSVC landing pads today:

* They only work about 80% of the time with optimizations enabled. For example when running the run-pass test suite a failing test will cause `compiletest` to segfault (b/c of a thread panic). There are also a large number of run-fail tests which will simply crash.
* Enabling landing pads caused the regression seen in #26915.

Overall it looks like LLVM's support for MSVC landing pads isn't as robust as we'd like for now, so let's take a little more time before we turn them on by default.


Closes #26915
Loading status checks…
cdcce3b
@bors

@bors bors merged commit 813cfa5 into rust-lang:master Jul 10, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:msvc-turn-off-unwinding branch Jul 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.