Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDerive Copy for std::ops::Range and RangeFrom #27186
Conversation
rust-highfive
assigned
pcwalton
Jul 21, 2015
This comment has been minimized.
This comment has been minimized.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This comment has been minimized.
This comment has been minimized.
|
These don't have it because they're iterators. let mut iter = 0..n;
for i in iter { if i > 2 { break; } }
iter.collect()Here |
This comment has been minimized.
This comment has been minimized.
|
Ok, so there was a reason. “The choice […] was made” seems to contradict “no decision has been made yet.” If the decision against implementing |
This comment has been minimized.
This comment has been minimized.
|
Yeah we've decided in the past to not take this, so I'm going to close this for now. |
alexcrichton
closed this
Jul 21, 2015
SimonSapin
deleted the
SimonSapin:patch-6
branch
Jul 21, 2015
This comment has been minimized.
This comment has been minimized.
|
@SimonSapin original phrasing was a bit off. What I meant to say was that no decision has been made for switching to linting (which my personal preference). |
durka
added a commit
to durka/rust
that referenced
this pull request
Jun 9, 2016
QuietMisdreavus
referenced this pull request
May 3, 2017
Closed
convert (usize, usize) for byte offsets into Range<usize> #12
dtolnay
referenced this pull request
Sep 18, 2017
Open
Do not implement Copy for types with "&mut self" methods #116
jturner314
referenced this pull request
Nov 3, 2017
Merged
Add support for slicing with subviews #377
This comment has been minimized.
This comment has been minimized.
sanmai-NL
commented
Jan 6, 2018
|
I favor a lint, since this code pattern is now not possible: let three_times = 0_u32..3_u32;
for _ in three_times {
...
}
for _ in three_times {
...
} |
SimonSapin commentedJul 21, 2015
RangeToandRangeFullalready have it.