Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign uprustc: Add a --cap-lints flag to the compiler #27260
Conversation
rust-highfive
assigned
nikomatsakis
Jul 24, 2015
This comment has been minimized.
This comment has been minimized.
|
r? @nrc |
rust-highfive
assigned
nrc
and unassigned
nikomatsakis
Jul 24, 2015
This comment has been minimized.
This comment has been minimized.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
referenced this pull request
Jul 24, 2015
Merged
Pass --cap-lints=allow instead of -Awarnings #1830
nrc
reviewed
Jul 28, 2015
src/librustc/session/config.rs
Outdated
| @@ -792,6 +794,8 @@ pub fn rustc_short_optgroups() -> Vec<RustcOptGroup> { | |||
| opt::multi("A", "allow", "Set lint allowed", "OPT"), | |||
| opt::multi("D", "deny", "Set lint denied", "OPT"), | |||
| opt::multi("F", "forbid", "Set lint forbidden", "OPT"), | |||
| opt::multi("", "cap-lints", "Prevent lint levels from being \ | |||
| more restrictive", "LEVEL"), | |||
This comment has been minimized.
This comment has been minimized.
nrc
Jul 28, 2015
Member
This message is not very user-friendly, perhaps "Set the most restrictive lint level. More restrictive lints are capped at this level". Or something more concise.
This comment has been minimized.
This comment has been minimized.
|
r=me, with or without an improved message |
alexcrichton
force-pushed the
alexcrichton:cap-lints
branch
from
2970156
to
b345437
Jul 29, 2015
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jul 29, 2015
This comment has been minimized.
This comment has been minimized.
bors
merged commit b345437
into
rust-lang:master
Jul 29, 2015
alexcrichton
deleted the
alexcrichton:cap-lints
branch
Aug 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedJul 24, 2015
This commit is an implementation of RFC 1193 which adds the ability to
the compiler to cap the lint level for the entire compilation session. This flag
will ensure that no lints will go above this level, and Cargo will primarily use
this flag passing
--cap-lints allowto all upstream dependencies.Closes #27259