Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate associated type defaults #27382

Merged
merged 3 commits into from Jul 31, 2015

Conversation

Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted regression-from-stable-to-nightly relnotes
Projects
None yet
Milestone
No milestone
3 participants
@brson @bors @alexcrichton
@brson
Copy link
Contributor

brson commented Jul 29, 2015

There are still problems in both the design and implementation of this, so we don't want it landing in 1.2.

cc @arielb1 @nikomatsakis

cc #27364

r? @alexcrichton

@brson brson added the beta-nominated label Jul 29, 2015

@rust-highfive rust-highfive assigned alexcrichton Jul 29, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 29, 2015

Hm, this doesn't actually work locally. Still testing.

@brson brson force-pushed the brson:gate-assoc-type branch from 52dd20e to a6ef178 Jul 29, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 29, 2015

OK, this is ready to go. I'd like to get this backported and I'll crater test on the beta branch.
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 29, 2015

r? @alexcrichton

@brson brson referenced this pull request Jul 29, 2015

Merged

Beta next #27387

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 29, 2015

Running through crater.

@brson brson force-pushed the brson:gate-assoc-type branch from a6ef178 to 0ce5b3b Jul 29, 2015

@brson
Feature gate associated type defaults 
There are multiple issues with them as designed and implemented.

cc #27364
Loading status checks…
a09bce1

@brson brson force-pushed the brson:gate-assoc-type branch from 0ce5b3b to a09bce1 Jul 29, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 30, 2015

4 regressions. No non-root regressions.
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 30, 2015

Those regressions are either for non-stable-compatible crates or those crates are not using the defaults.

@brson brson added regression-from-stable-to-nightly relnotes beta-nominated and removed beta-nominated labels Jul 30, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 30, 2015

@aturon is satisfied with this breakage. @bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 30, 2015

📌 Commit a09bce1 has been approved by brson

@brson brson added the beta-accepted label Jul 30, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 30, 2015

@bors r=aturon
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 30, 2015

📌 Commit a09bce1 has been approved by brson

@brson brson removed the beta-nominated label Jul 30, 2015

bors added a commit that referenced this pull request Jul 30, 2015

@bors
Auto merge of #27382 - brson:gate-assoc-type, r=brson 
There are still problems in both the design and implementation of this, so we don't want it landing in 1.2.

cc @arielb1 @nikomatsakis 

cc #27364

r? @alexcrichton
d5fc0da
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 30, 2015

⌛️ Testing commit a09bce1 with merge d5fc0da...
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 30, 2015

💔 Test failed - auto-mac-64-opt
@brson
Fix tests
Loading status checks…
4aaf1be
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

brson commented Jul 30, 2015

@bors r=alexcrichton
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 30, 2015

📌 Commit 4aaf1be has been approved by alexcrichton

bors added a commit that referenced this pull request Jul 31, 2015

@bors
Auto merge of #27382 - brson:gate-assoc-type, r=alexcrichton 
There are still problems in both the design and implementation of this, so we don't want it landing in 1.2.

cc @arielb1 @nikomatsakis 

cc #27364

r? @alexcrichton
Loading status checks…
8d2eb59
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Jul 31, 2015

⌛️ Testing commit 4aaf1be with merge 8d2eb59...
@bors

@bors bors merged commit 4aaf1be into rust-lang:master Jul 31, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

This was referenced Jul 31, 2015

Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.