Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get `make check` working on MSVC #27786

Merged
merged 1 commit into from Aug 14, 2015

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @rust-highfive @brson @bors @tamird
@alexcrichton
Copy link
Member

alexcrichton commented Aug 13, 2015

  • An apparent bug in VS 2013's implementation of the exp2 function is worked
    around in one of flt2dec's tests.

Turns out this was the only fix necessary!

@rust-highfive rust-highfive assigned brson Aug 13, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Aug 13, 2015

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Aug 13, 2015

Ah and when I say "MSVC" I really mean 64-bit MSVC, unwinding doesn't work so hot in 32-bit MSVC just yet.

Also, here's an example of a successful test run on the bots in dev: http://54.176.156.253/builders/auto-win-msvc-64-opt/builds/42
src/libcoretest/num/flt2dec/strategy/dragon.rs Outdated
// in VS 2013 it returns a double with the bit pattern 0x2 and in VS 2015 it
// returns 0x20000.
//
// For not just ignore this test entirely on MSVC as it's tested elsewhere

This comment has been minimized.

Sign in to view
Copy link
@tamird

tamird Aug 13, 2015

Contributor

s/not/now
@alexcrichton
Get `make check` working on MSVC 
* An apparent bug in VS 2013's implementation of the `exp2` function is worked
  around in one of flt2dec's tests.
Loading status checks…
60ac0d8

@alexcrichton alexcrichton force-pushed the alexcrichton:start-testing-msvc branch from fbd2658 to 60ac0d8 Aug 13, 2015

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Aug 13, 2015

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 13, 2015

📌 Commit 60ac0d8 has been approved by brson
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 13, 2015

⌛️ Testing commit 60ac0d8 with merge 91b14bb...

bors added a commit that referenced this pull request Aug 13, 2015

@bors
Auto merge of #27786 - alexcrichton:start-testing-msvc, r=brson 
* An apparent bug in VS 2013's implementation of the `exp2` function is worked
  around in one of flt2dec's tests.

Turns out this was the only fix necessary!
91b14bb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 13, 2015

💔 Test failed - auto-mac-64-opt
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Aug 13, 2015

@bors: retry

On Thu, Aug 13, 2015 at 1:34 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/6074

—
Reply to this email directly or view it on GitHub
#27786 (comment).

bors added a commit that referenced this pull request Aug 14, 2015

@bors
Auto merge of #27786 - alexcrichton:start-testing-msvc, r=brson 
* An apparent bug in VS 2013's implementation of the `exp2` function is worked
  around in one of flt2dec's tests.

Turns out this was the only fix necessary!
Loading status checks…
033e127
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 14, 2015

⌛️ Testing commit 60ac0d8 with merge 033e127...
@bors

@bors bors merged commit 60ac0d8 into rust-lang:master Aug 14, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:start-testing-msvc branch Aug 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.