Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Don't panic if some tests failed #27869

Merged
merged 1 commit into from Aug 18, 2015

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@alexcrichton @rust-highfive @brson @bors @nagisa @huonw
@alexcrichton
Copy link
Member

alexcrichton commented Aug 17, 2015

This commit removes the call to panic!("Some tests failed") at the end of all
tests run when running with libtest. The panic is replaced with
std::process::exit to have a nonzero error code, but this change both:

  1. Makes the test runner no longer print out the extraneous panic message at the
    end of a failing test run that some tests failed. (this is already summarized
    in the output of the test run).
  2. When running tests with RUST_BACKTRACE set it removes an extraneous
    backtrace from the output (only failing tests will have their backtraces in
    the output.
@alexcrichton
test: Don't panic if some tests failed 
This commit removes the call to `panic!("Some tests failed")` at the end of all
tests run when running with libtest. The panic is replaced with
`std::process::exit` to have a nonzero error code, but this change both:

1. Makes the test runner no longer print out the extraneous panic message at the
   end of a failing test run that some tests failed. (this is already summarized
   in the output of the test run).
2. When running tests with `RUST_BACKTRACE` set it removes an extraneous
   backtrace from the output (only failing tests will have their backtraces in
   the output.
Loading status checks…
bfc4583
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Aug 17, 2015

r? @brson

@rust-highfive rust-highfive assigned brson Aug 17, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Aug 17, 2015

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Aug 17, 2015

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 17, 2015

📌 Commit bfc4583 has been approved by brson
@nagisa

This comment has been minimized.

Sign in to view
Copy link
Contributor

nagisa commented Aug 17, 2015

Just wanted to mention that this prevents dropping of opts variable from above. Might or might not be something to consider.
@huonw

This comment has been minimized.

Sign in to view
Copy link
Member

huonw commented Aug 17, 2015

@nagisa do you have a specific problem in mind because of that? (NB. the process is exiting and the operating system will automatically reclaim the memory.)
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 18, 2015

⌛️ Testing commit bfc4583 with merge a91f19f...

bors added a commit that referenced this pull request Aug 18, 2015

@bors
Auto merge of #27869 - alexcrichton:libtest-panic, r=brson 
This commit removes the call to `panic!("Some tests failed")` at the end of all
tests run when running with libtest. The panic is replaced with
`std::process::exit` to have a nonzero error code, but this change both:

1. Makes the test runner no longer print out the extraneous panic message at the
   end of a failing test run that some tests failed. (this is already summarized
   in the output of the test run).
2. When running tests with `RUST_BACKTRACE` set it removes an extraneous
   backtrace from the output (only failing tests will have their backtraces in
   the output.
Loading status checks…
a91f19f
@nagisa

This comment has been minimized.

Sign in to view
Copy link
Contributor

nagisa commented Aug 18, 2015

Only the fact that valgrind might complain.
On Aug 18, 2015 2:57 AM, "Huon Wilson" notifications@github.com wrote:

@nagisa https://github.com/nagisa do you have a specific problem in
mind because of that? (NB. the process is exiting and the operating system
will automatically reclaim the memory.)

—
Reply to this email directly or view it on GitHub
#27869 (comment).
@bors

@bors bors merged commit bfc4583 into rust-lang:master Aug 18, 2015
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
homu Test successful
Details

@alexcrichton alexcrichton deleted the alexcrichton:libtest-panic branch Aug 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.