Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement RFC 1194 #28043

Merged
merged 1 commit into from Aug 29, 2015

Conversation

Reviewers
No reviews
Assignees

@Gankro Gankro

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@apasel422 @rust-highfive @brson @alexcrichton @bors @Gankro
@apasel422
Copy link
Member

apasel422 commented Aug 27, 2015

closes #28050

@rust-highfive rust-highfive assigned brson Aug 27, 2015

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Aug 27, 2015

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)
@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Aug 27, 2015

r? @Gankro

@rust-highfive rust-highfive assigned Gankro and unassigned brson Aug 27, 2015

@alexcrichton alexcrichton referenced this pull request Aug 27, 2015

Closed

Set recovery methods #28050

src/libstd/collections/hash/set.rs Outdated
/// The value may be any borrowed form of the set's value type, but
/// `Hash` and `Eq` on the borrowed form *must* match those for
/// the value type.
#[unstable(feature = "set_recovery", issue = "0")]

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Aug 27, 2015

Member

(just to make sure this comment isn't lost)

These issues can be wired up to the tracking issue for the RFC now
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Aug 27, 2015

Thanks @apasel422! Was this also going to take care of BTreeSet? Or is that holding off for future changes?
@apasel422

This comment has been minimized.

Sign in to view
Copy link
Member Author

apasel422 commented Aug 27, 2015

I just haven't gotten around to making the changes for BTreeSet. I'll
update this PR once I have.

On Thursday, August 27, 2015, Alex Crichton notifications@github.com
wrote:

Thanks @apasel422 https://github.com/apasel422! Was this also going to
take care of BTreeSet? Or is that holding off for future changes?

—
Reply to this email directly or view it on GitHub
#28043 (comment).
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Aug 27, 2015

Ok, well in the meantime these look good to me :)
@apasel422
implement RFC 1194
Loading status checks…
f9b63d3

@apasel422 apasel422 changed the title WIP: implement RFC 1194 implement RFC 1194 Aug 28, 2015

@apasel422

This comment has been minimized.

Sign in to view
Copy link
Member Author

apasel422 commented Aug 28, 2015

Updated with correct issue numbers and BTreeSet methods.
src/libcollections/btree/map.rs
Leaf(_) => return None,
Internal(internal_handle) => {
cur_node = internal_handle.into_edge();
continue;

This comment has been minimized.

Sign in to view
Copy link
@alexcrichton

alexcrichton Aug 28, 2015

Member

I think this continue can be omitted

This comment has been minimized.

Sign in to view
Copy link
@apasel422

apasel422 Aug 28, 2015

Author Member

This is actually copied from BTreeMap::get, so I opted to keep the code as similar as possible.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member

alexcrichton commented Aug 28, 2015

@bors: r+ f9b63d3

Thanks @apasel422!

bors added a commit that referenced this pull request Aug 29, 2015

@bors
Auto merge of #28043 - apasel422:rfc-1194, r=alexcrichton
Loading status checks…
d503524
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Aug 29, 2015

⌛️ Testing commit f9b63d3 with merge d503524...
@bors

@bors bors merged commit f9b63d3 into rust-lang:master Aug 29, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@apasel422 apasel422 deleted the apasel422:rfc-1194 branch Aug 29, 2015

@bors bors referenced this pull request Aug 29, 2015

Closed

Implement append and split_off for BTreeMap and BTreeSet #26227

@mbrubeck mbrubeck referenced this pull request Apr 17, 2017

Closed

HashSet should have a get function #691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.