Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upcheck upvars in closures that are in statics #28131
Conversation
rust-highfive
assigned
pnkfelix
Aug 31, 2015
arielb1
reviewed
Aug 31, 2015
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| // check that borrowck looks inside consts/statics |
This comment has been minimized.
This comment has been minimized.
arielb1
Aug 31, 2015
Author
Contributor
Now that this code type-checks, it would be a shame if borrowck doesn't actually look inside.
This comment has been minimized.
This comment has been minimized.
|
ping r? @pnkfelix |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Sep 30, 2015
This comment has been minimized.
This comment has been minimized.
|
|
arielb1
force-pushed the
arielb1:static-upvars
branch
from
565da72
to
c01e050
Oct 1, 2015
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Oct 1, 2015
This comment has been minimized.
This comment has been minimized.
bors
merged commit c01e050
into
rust-lang:master
Oct 1, 2015
arielb1
referenced this pull request
Oct 5, 2015
Closed
Regression in type inference of casting in constants #28801
This comment has been minimized.
This comment has been minimized.
rust-highfive
added
the
beta-nominated
label
Oct 5, 2015
alexcrichton
added
the
T-compiler
label
Oct 5, 2015
This comment has been minimized.
This comment has been minimized.
|
@rust-lang/compiler I'm in favor of backporting this PR to beta. |
nikomatsakis
added
the
beta-accepted
label
Oct 16, 2015
This comment has been minimized.
This comment has been minimized.
|
Accepted as fixes a regression. |
alexcrichton
removed
the
beta-nominated
label
Oct 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
arielb1 commentedAug 31, 2015
Fixes #23057
Fixes #27890
Fixes #28099
Fixes #28113
r? @pnkfelix